Issue 12302005: views: Start sending mouse events using the EventDispatch interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12302005: views: Start sending mouse events using the EventDispatch interface. (Closed)

Created:
7 years, 10 months ago by sadrul

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Start sending mouse events using the EventDispatch interface. This fills in the implementation for View::OnMouseEvent. However, none of these are used yet to dispatch the events from RootView. There will be subsequent CLs that use this code to dispatch different types of mouse events. BUG=173235 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183086

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -38 lines)			Patch
M	ui/views/view.h	View	4 chunks	+23 lines, -23 lines	0 comments	Download
M	ui/views/view.cc	View	4 chunks	+50 lines, -9 lines	0 comments	Download
M	ui/views/widget/root_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/root_view.cc	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

I am splitting https://codereview.chromium.org/12212117/ into pieces fro landing, since some of the tests seem to ...

7 years, 10 months ago (2013-02-18 09:41:08 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages