Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12300042: Update idlsync.py to pull in dependencies required for chrome api generation. (Closed)

Created:
7 years, 10 months ago by benwells
Modified:
7 years, 10 months ago
Reviewers:
vsm
Base URL:
git://github.com/dart-lang/bleeding_edge.git@master
Visibility:
Public.

Description

Update idlsync.py to pull in dependencies required for chrome api generation. BUG=None Committed: https://code.google.com/p/dart/source/detail?r=18955

Patch Set 1 #

Patch Set 2 : sashab clone of previous patch (without DEPS changes) #

Patch Set 3 : Crash from previous upload #

Patch Set 4 : idlsync.py changes only #

Patch Set 5 : From proper checkout #

Patch Set 6 : From another checkout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14962 lines, -8175 lines) Patch
A + third_party/chrome/ppapi/generators/README View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/chrome/ppapi/generators/generator.py View 1 4 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_ast.py View 1 4 1 chunk +194 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_c_header.py View 1 4 1 chunk +299 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_c_proto.py View 1 4 1 chunk +738 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_diff.py View 1 4 1 chunk +354 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_gen_pnacl.py View 1 4 1 chunk +242 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_gen_wrapper.py View 1 4 1 chunk +461 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_generator.py View 1 4 1 chunk +277 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_lexer.py View 1 4 1 chunk +349 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_lint.py View 1 4 1 chunk +122 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_log.py View 1 4 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_namespace.py View 1 4 1 chunk +251 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_node.py View 1 4 1 chunk +491 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_option.py View 1 4 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_outfile.py View 1 4 1 chunk +181 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_parser.py View 1 4 1 chunk +1227 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_propertynode.py View 1 4 1 chunk +197 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_release.py View 1 4 1 chunk +351 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_tests.py View 1 4 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_thunk.py View 1 4 1 chunk +441 lines, -0 lines 0 comments Download
A third_party/chrome/ppapi/generators/idl_visitor.py View 1 4 1 chunk +81 lines, -0 lines 0 comments Download
A + third_party/chrome/third_party/ply/README View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/chrome/third_party/ply/__init__.py View 1 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/chrome/third_party/ply/lex.py View 1 4 1 chunk +1058 lines, -0 lines 0 comments Download
A third_party/chrome/third_party/ply/yacc.py View 1 4 1 chunk +3276 lines, -0 lines 0 comments Download
D third_party/chrome/tools/PRESUBMIT.py View 1 4 1 chunk +0 lines, -20 lines 0 comments Download
A third_party/chrome/tools/bisect-builds.py View 1 4 1 chunk +689 lines, -0 lines 0 comments Download
A third_party/chrome/tools/bisect-perf-regression.py View 1 4 1 chunk +1004 lines, -0 lines 0 comments Download
A third_party/chrome/tools/bisect_test.py View 1 4 1 chunk +53 lines, -0 lines 0 comments Download
D third_party/chrome/tools/cc_generator.py View 1 4 1 chunk +0 lines, -811 lines 0 comments Download
D third_party/chrome/tools/code.py View 1 4 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/chrome/tools/code_test.py View 1 4 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/chrome/tools/compiler.py View 1 4 1 chunk +0 lines, -207 lines 0 comments Download
D third_party/chrome/tools/cpp_type_generator.py View 1 4 1 chunk +0 lines, -306 lines 0 comments Download
D third_party/chrome/tools/cpp_type_generator_test.py View 1 4 1 chunk +0 lines, -177 lines 0 comments Download
D third_party/chrome/tools/cpp_util.py View 1 4 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/chrome/tools/cpp_util_test.py View 1 4 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/chrome/tools/diagnose-me.py View 1 4 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/chrome/tools/find_depot_tools.py View 1 4 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/chrome/tools/gyp-explain.py View 1 4 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/chrome/tools/gypv8sh.py View 1 4 1 chunk +55 lines, -0 lines 0 comments Download
D third_party/chrome/tools/h_generator.py View 1 4 1 chunk +0 lines, -368 lines 0 comments Download
D third_party/chrome/tools/highlighters/__init__.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
third_party/chrome/tools/highlighters/hilite_me_highlighter.py View 1 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/chrome/tools/highlighters/none_highlighter.py View 1 4 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/chrome/tools/highlighters/pygments_highlighter.py View 1 4 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/chrome/tools/idl_schema.py View 1 4 1 chunk +0 lines, -382 lines 0 comments Download
D third_party/chrome/tools/idl_schema_test.py View 1 4 1 chunk +0 lines, -153 lines 0 comments Download
A third_party/chrome/tools/include_tracer.py View 1 4 1 chunk +206 lines, -0 lines 0 comments Download
A third_party/chrome/tools/ipc_messages_log.py View 1 4 1 chunk +168 lines, -0 lines 0 comments Download
A third_party/chrome/tools/json_comment_eater.py View 1 4 1 chunk +40 lines, -0 lines 0 comments Download
D third_party/chrome/tools/json_parse.py View 1 4 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/chrome/tools/json_schema.py View 1 4 1 chunk +0 lines, -46 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/PRESUBMIT.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/README View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/cc_generator.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/code.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/code_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/compiler.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/cpp_type_generator.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/cpp_type_generator_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/cpp_util.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/cpp_util_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/h_generator.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/highlighters/__init__.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/highlighters/hilite_me_highlighter.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/highlighters/none_highlighter.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/highlighters/pygments_highlighter.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/idl_schema.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/idl_schema_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/json_parse.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/json_schema.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/json_schema_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/model.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/model_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/preview.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/schema_bundle_generator.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/schema_util.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/schema_util_test.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
third_party/chrome/tools/json_schema_compiler/test/additional_properties.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/any.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/arrays.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/browser_action.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/callbacks.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/choices.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/content_settings.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/crossref.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/dependency_tester.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/enums.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/font_settings.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/forbidden.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/functions_as_parameters.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/functions_on_types.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/idl_basics.idl View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/idl_callback_arrays.idl View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/idl_object_types.idl View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/idl_reserved_words.idl View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/json_schema_test.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/objects.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/permissions.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/simple_api.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/tabs.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/test/windows.json View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/chrome/tools/json_schema_compiler/util_cc_helper.py View 1 4 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/chrome/tools/json_schema_test.py View 1 4 1 chunk +0 lines, -79 lines 0 comments Download
A third_party/chrome/tools/licenses.py View 1 4 1 chunk +469 lines, -0 lines 0 comments Download
third_party/chrome/tools/model.py View 1 4 1 chunk +0 lines, -497 lines 0 comments Download
D third_party/chrome/tools/model_test.py View 1 4 1 chunk +0 lines, -103 lines 0 comments Download
A third_party/chrome/tools/nocompile_driver.py View 1 4 1 chunk +472 lines, -0 lines 0 comments Download
A third_party/chrome/tools/omahaproxy.py View 1 4 1 chunk +90 lines, -0 lines 0 comments Download
D third_party/chrome/tools/preview.py View 1 4 1 chunk +0 lines, -361 lines 0 comments Download
A third_party/chrome/tools/safely-roll-webkit.py View 1 4 1 chunk +113 lines, -0 lines 0 comments Download
D third_party/chrome/tools/schema_bundle_generator.py View 1 4 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/chrome/tools/schema_util.py View 1 4 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/chrome/tools/schema_util_test.py View 1 4 1 chunk +0 lines, -25 lines 0 comments Download
A third_party/chrome/tools/sort-headers.py View 1 4 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/chrome/tools/sync-webkit-git.py View 1 4 1 chunk +221 lines, -0 lines 0 comments Download
D third_party/chrome/tools/test/additional_properties.json View 1 4 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/chrome/tools/test/any.json View 1 4 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/chrome/tools/test/arrays.json View 1 4 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/chrome/tools/test/browser_action.json View 1 4 1 chunk +0 lines, -272 lines 0 comments Download
D third_party/chrome/tools/test/callbacks.json View 1 4 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/chrome/tools/test/choices.json View 1 4 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/chrome/tools/test/content_settings.json View 1 4 1 chunk +0 lines, -221 lines 0 comments Download
D third_party/chrome/tools/test/crossref.json View 1 4 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/chrome/tools/test/dependency_tester.json View 1 4 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/chrome/tools/test/enums.json View 1 4 1 chunk +0 lines, -212 lines 0 comments Download
D third_party/chrome/tools/test/font_settings.json View 1 4 1 chunk +0 lines, -550 lines 0 comments Download
D third_party/chrome/tools/test/forbidden.json View 1 4 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/chrome/tools/test/functions_as_parameters.json View 1 4 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/chrome/tools/test/functions_on_types.json View 1 4 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/chrome/tools/test/idl_basics.idl View 1 4 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/chrome/tools/test/idl_callback_arrays.idl View 1 4 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/chrome/tools/test/idl_object_types.idl View 1 4 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/chrome/tools/test/idl_reserved_words.idl View 1 4 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/chrome/tools/test/json_schema_test.json View 1 4 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/chrome/tools/test/objects.json View 1 4 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/chrome/tools/test/permissions.json View 1 4 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/chrome/tools/test/simple_api.json View 1 4 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/chrome/tools/test/tabs.json View 1 4 1 chunk +0 lines, -769 lines 0 comments Download
D third_party/chrome/tools/test/windows.json View 1 4 1 chunk +0 lines, -264 lines 0 comments Download
A third_party/chrome/tools/unused-symbols-report.py View 1 4 1 chunk +171 lines, -0 lines 0 comments Download
D third_party/chrome/tools/util_cc_helper.py View 1 4 1 chunk +0 lines, -79 lines 0 comments Download
M tools/dom/scripts/idlsync.py View 1 7 chunks +36 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
This feels a bit dirty but does the job. The structure under third_party/chrome/ matches the ...
7 years, 10 months ago (2013-02-20 03:06:04 UTC) #1
vsm
LGTM Thanks for the additional cleanups in DEPS and idlsync.py.
7 years, 10 months ago (2013-02-20 15:03:25 UTC) #2
benwells
Cool, thanks. I can get Sasha to commit this for me, but longer term maybe ...
7 years, 10 months ago (2013-02-20 21:14:09 UTC) #3
sashab
On 2013/02/20 21:14:09, benwells wrote: > Cool, thanks. I can get Sasha to commit this ...
7 years, 10 months ago (2013-02-20 23:41:52 UTC) #4
benwells
On 2013/02/20 23:41:52, sasha_b wrote: > On 2013/02/20 21:14:09, benwells wrote: > > Cool, thanks. ...
7 years, 10 months ago (2013-02-20 23:49:30 UTC) #5
benwells
On 2013/02/20 23:49:30, benwells wrote: > On 2013/02/20 23:41:52, sasha_b wrote: > > On 2013/02/20 ...
7 years, 10 months ago (2013-02-22 06:26:19 UTC) #6
benwells
7 years, 10 months ago (2013-02-25 03:55:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r18955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698