Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 12300005: Fix parameters for git_cl and gcl (Closed)

Created:
7 years, 10 months ago by iannucci
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix unittest too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M gcl.py View 1 chunk +2 lines, -1 line 0 comments Download
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/gcl_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
iannucci
I should learn never to do *_ :(
7 years, 10 months ago (2013-02-17 05:30:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/12300005/2001
7 years, 10 months ago (2013-02-17 05:31:01 UTC) #2
commit-bot: I haz the power
Change committed as 183022
7 years, 10 months ago (2013-02-17 05:33:37 UTC) #3
M-A Ruel
7 years, 10 months ago (2013-02-17 14:00:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698