gcl.py - Issue 12300005: Fix parameters for git_cl and gcl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 12300005: Fix parameters for git_cl and gcl (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fix unittest too Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 56655c294c5df87d85b1d2528c4351699b509055..ce6edabab23214f7e5bceca346bc895305e2a726 100755

--- a/gcl.py

+++ b/gcl.py

@@ -1045,7 +1045,8 @@ def CMDcommit(change_info, args):

elif revision:

change_info.description += "\nCommitted: " + revision

change_info.CloseIssue()

- props = change_info.RpcServer().get_issue_properties(change_info.issue)

+ props = change_info.RpcServer().get_issue_properties(

+ change_info.issue, False)

patch_num = len(props['patchsets'])

comment = "Committed patchset #%d manually as r%s" % (patch_num, revision)

comment += ' (presubmit successful).' if not bypassed else '.'

« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »