Fix top-level context menus sorting by name

chrome/browser/extensions/context_menu_matcher.h

Index: chrome/browser/extensions/context_menu_matcher.h
diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h
index 3dee9bdb268470560e7ccba20963314486de51be..e160afd6269eab43a288fa5e3e35255082ff66d5 100644
--- a/chrome/browser/extensions/context_menu_matcher.h
+++ b/chrome/browser/extensions/context_menu_matcher.h
@@ -40,6 +40,11 @@ class ContextMenuMatcher {
 
   void Clear();
 
+  // This function returns the top level context menu title of an extension
+  // based on a printable selection text.
+  std::string GetTopLevelContextMenuTitle(const std::string& extension_id,
+                                          const string16& selection_text);

[Avi (use Gerrit), 2013/06/05 14:34:10]

If this returns a string visible in the UI, then it should return a string16.

(Oh, and while you're here, use |base::string16|.)

[François Beaufort, 2013/06/06 09:07:37]

This function doesn't return a string visible in the UI.
It is there to help sort the Context Menu items. See
https://chromiumcodereview.appspot.com/12299013/diff/41001/chrome/browser/tab...

On 2013/06/05 14:34:10, Avi wrote:

+
   bool IsCommandIdChecked(int command_id) const;
   bool IsCommandIdEnabled(int command_id) const;
   void ExecuteCommand(int command_id,
@@ -49,6 +54,12 @@ class ContextMenuMatcher {
  private:
   friend class ::ExtensionContextMenuBrowserTest;
 
+  bool GetRelevantExtensionTopLevelItems(
+      const std::string& extension_id,
+      const Extension** extension,
+      bool* can_cross_incognito,
+      MenuItem::List& items);
+
   MenuItem::List GetRelevantExtensionItems(
       const MenuItem::List& items,
       bool can_cross_incognito);