Fix top-level context menus sorting by name

chrome/browser/extensions/context_menu_matcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CONTEXT_MENU_MATCHER_H_
 #define CHROME_BROWSER_EXTENSIONS_CONTEXT_MENU_MATCHER_H_
 
 #include <map>
 
 #include "base/callback.h"
@@ skipping 22 matching lines @@
 
   // This is a helper function to append items for one particular extension.
   // The |index| parameter is used for assigning id's, and is incremented for
   // each item actually added.
   void AppendExtensionItems(const std::string& extension_id,
                             const string16& selection_text,
                             int* index);
 
   void Clear();
 
+  // This function returns the top level context menu title of an extension
+  // based on a printable selection text.
+  std::string GetTopLevelContextMenuTitle(const std::string& extension_id,
+                                          const string16& selection_text);

[Avi (use Gerrit), 2013/06/05 14:34:10]

If this returns a string visible in the UI, then it should return a string16.

(Oh, and while you're here, use |base::string16|.)

[François Beaufort, 2013/06/06 09:07:37]

This function doesn't return a string visible in the UI.
It is there to help sort the Context Menu items. See
https://chromiumcodereview.appspot.com/12299013/diff/41001/chrome/browser/tab...

On 2013/06/05 14:34:10, Avi wrote:

+
   bool IsCommandIdChecked(int command_id) const;
   bool IsCommandIdEnabled(int command_id) const;
   void ExecuteCommand(int command_id,
                       content::WebContents* web_contents,
                       const content::ContextMenuParams& params);
 
  private:
   friend class ::ExtensionContextMenuBrowserTest;
 
+  bool GetRelevantExtensionTopLevelItems(
+      const std::string& extension_id,
+      const Extension** extension,
+      bool* can_cross_incognito,
+      MenuItem::List& items);
+
   MenuItem::List GetRelevantExtensionItems(
       const MenuItem::List& items,
       bool can_cross_incognito);
 
   // Used for recursively adding submenus of extension items.
   void RecursivelyAppendExtensionItems(const MenuItem::List& items,
                                        bool can_cross_incognito,
                                        const string16& selection_text,
                                        ui::SimpleMenuModel* menu_model,
                                        int* index);
@@ skipping 15 matching lines @@
 
   // Keep track of and clean up menu models for submenus.
   ScopedVector<ui::SimpleMenuModel> extension_menu_models_;
 
   DISALLOW_COPY_AND_ASSIGN(ContextMenuMatcher);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CONTEXT_MENU_MATCHER_H_