Add new snackbar features to prepare for omnibox geolocation snackbar.

Add new snackbar features to prepare for omnibox geolocation snackbar.

This adds a few new features to snackbars to prepare for the geolocation
disclosure snackbar:
 - Snackbars now interact nicely with the keyboard. Snackbars won't
   overlap the keyboard; instead, they're appear above the keyboard if
   the keyboard is showing, and will drop down the bottom of the screen
   when the keyboard is hidden. This is achieved using
   View.getWindowVisibleDisplayFrame() to find where the keyboard is
   showing.
 - Snackbars now support multiline text. In this case, the snackbar text
   won't be ellipsized and TemplatePreservingTextView will act like a
   normal TextView.
 - Snackbar text can now be any CharSequence, not just a String. This
   will be used to display snackbars that contain spans.

Implementation change: this adds a Snackbar class, which allows greater
flexibility when configuring snackbars. SnackbarManager.showSnackbar()
now acceps a single Snackbar, instead of a long list of parameters.

BUG=505481
Committed: https://crrev.com/2b2cd69f0833466cd9b818575404bf05103ca7bd
Cr-Commit-Position: refs/heads/master@{#337966}

[newt (away), 2015-07-08 22:12:55]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org, ianwen@chromium.org

[newt (away), 2015-07-08 22:12:56]

PTAL

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/col...
File chrome/android/java/res/color/snack_bar_button_color.xml (left):

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/col...
chrome/android/java/res/color/snack_bar_button_color.xml:1: <?xml version="1.0"
encoding="utf-8"?>
Renamed "snack_bar..." to "snackbar..." for consistency. Likewise with
snack_bar.xml.

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/snackbar.xml (left):

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/snackbar.xml:20: android:singleLine="true"
This is now set programmatically (and only in some cases) in
SnackbarPopupWindow.

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/snackbar.xml (right):

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/snackbar.xml:10:
android:minHeight="@dimen/snackbar_min_height"
single-line snackbar height is still 48dp

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1229733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:142:
* TODO(newt): delete this method. Update callers to use {@link
#showSnackbar(Snackbar)}.
will do this as a separate CL

[David Trainor- moved to gerrit, 2015-07-08 22:54:38]

Looks awesome.  lgtm.

[newt (away), 2015-07-09 00:01:17]

Ian, do you want to take a look?

[Ian Wen, 2015-07-09 00:39:26]

lgtm! Thanks for the great change.

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:91:
private View mParent;
Since we are passing windows directly, maybe rename mParent to mDecorView,
mRootView, mWindowRootView, or mDinosaur?

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/TemplatePreservingTextView.java
(left):

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/TemplatePreservingTextView.java:20:
private static final String DEFAULT_TEMPLATE = "%1$s";
Is it deleted?

[newt (away), 2015-07-09 01:16:13]

Addressed comments. Also, fixed things in multiwindow mode (at least on S3 and
S6).

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:91:
private View mParent;
On 2015/07/09 00:39:26, Ian Wen wrote:
> Since we are passing windows directly, maybe rename mParent to mDecorView,
> mRootView, mWindowRootView, or mDinosaur?

I strongly considered mDinosaur... but ended up going with mDecor.

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/TemplatePreservingTextView.java
(left):

https://chromiumcodereview.appspot.com/1229733002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/TemplatePreservingTextView.java:20:
private static final String DEFAULT_TEMPLATE = "%1$s";
On 2015/07/09 00:39:26, Ian Wen wrote:
> Is it deleted?

Yes. Now we just use "null" to indicate that templating should be skipped.

[newt (away), 2015-07-09 01:16:34]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-07-09 01:16:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org,
dtrainor@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1229733002/#ps20001
(title: "Ian's comments; fixed snackbar location in multiwindow mode when
keyboard is visible")

[commit-bot: I haz the power, 2015-07-09 01:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229733002/20001

[commit-bot: I haz the power, 2015-07-09 01:57:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-09 01:58:04]

Patchset 2 (id:??) landed as
https://crrev.com/2b2cd69f0833466cd9b818575404bf05103ca7bd
Cr-Commit-Position: refs/heads/master@{#337966}