Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1229733002: Add new snackbar features to prepare for omnibox geolocation snackbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ian's comments; fixed snackbar location in multiwindow mode when keyboard is visible Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/snackbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 <item name="android:textColorLink">@color/light_active_color</item> 380 <item name="android:textColorLink">@color/light_active_color</item>
381 <item name="colorPrimary">@color/light_active_color</item> 381 <item name="colorPrimary">@color/light_active_color</item>
382 <item name="colorAccent">@color/light_active_color</item> 382 <item name="colorAccent">@color/light_active_color</item>
383 </style> 383 </style>
384 384
385 <!-- Misc styles --> 385 <!-- Misc styles -->
386 <style name="SnackbarAnimation"> 386 <style name="SnackbarAnimation">
387 <item name="android:windowEnterAnimation">@anim/snackbar_in</item> 387 <item name="android:windowEnterAnimation">@anim/snackbar_in</item>
388 <item name="android:windowExitAnimation">@anim/snackbar_out</item> 388 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
389 </style> 389 </style>
390 <style name="SnackbarAnimationWithKeyboard">
391 <item name="android:windowEnterAnimation">@anim/snackbar_in_with_keyboar d</item>
392 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
393 </style>
390 <style name="LocationBarButton"> 394 <style name="LocationBarButton">
391 <item name="android:background">@null</item> 395 <item name="android:background">@null</item>
392 </style> 396 </style>
393 <style name="ToolbarButton"> 397 <style name="ToolbarButton">
394 <item name="android:background">?attr/selectableItemBackground</item> 398 <item name="android:background">?attr/selectableItemBackground</item>
395 <item name="android:layout_width">48dp</item> 399 <item name="android:layout_width">48dp</item>
396 <item name="android:layout_height">56dp</item> 400 <item name="android:layout_height">56dp</item>
397 <item name="android:scaleType">center</item> 401 <item name="android:scaleType">center</item>
398 </style> 402 </style>
399 </resources> 403 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/snackbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698