Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 12291002: cc: Don't sync tilings to layers that don't draw content. (Closed)

Created:
7 years, 10 months ago by danakj
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Don't sync tilings to layers that don't draw content. If a layer is drawsContent == false, it should have no tilings, which we assert to be the case. When the pending tree is created, tilings are synced back to the pending tree, but not for layers that do not draw content in the pending tree. However, if we create a tiling for the active tree later, we sync that tiling to the pending tree even if the layer does not draw content, creating a situation where a non-content- drawing layer has tilings but it should not. Similarly, if the pending tree creates a tiling, but the layer already exists in the active tree in a state that does not draw content, the tiling should not be added to the active layer. R=reveman,enne BUG=176524 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/picture_layer_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 10 months ago (2013-02-15 19:02:15 UTC) #1
reveman
lgtm but enne should review before landing
7 years, 10 months ago (2013-02-18 22:05:59 UTC) #2
enne (OOO)
lgtm2
7 years, 10 months ago (2013-02-19 23:25:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12291002/1
7 years, 10 months ago (2013-02-19 23:28:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12291002/1
7 years, 10 months ago (2013-02-20 04:45:18 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 04:52:18 UTC) #6
Message was sent while issue was closed.
Change committed as 183410

Powered by Google App Engine
This is Rietveld 408576698