Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/auxiliary_profile_impl_android.h

Index: chrome/browser/autofill/auxiliary_profile_impl_android.h
diff --git a/chrome/browser/autofill/auxiliary_profile_impl_android.h b/chrome/browser/autofill/auxiliary_profile_impl_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..cdcec076555d0458f853c80b28f846377e252a70
--- /dev/null
+++ b/chrome/browser/autofill/auxiliary_profile_impl_android.h
@@ -0,0 +1,40 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_
+#define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_
+
+#include <jni.h>
+#include "base/guid.h"
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+#include "base/string16.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/autofill/autofill_profile.h"
+#include "chrome/browser/autofill/i_auxiliary_profile_loader.h"
+
+class AuxiliaryProfilesImpl {

[David Trainor- moved to gerrit, 2013/02/27 07:49:28]

Do we need Impl on this if there isn't an interface?  Can we call this
AuxiliaryProfilesAndroid?

Make profile -> profiles in the file name.

[apiccion, 2013/02/28 01:31:04]

Done.

[apiccion, 2013/02/28 01:31:04]

Done.

+ public:
+    AuxiliaryProfilesImpl(ScopedVector<AutofillProfile>* profiles,

[David Trainor- moved to gerrit, 2013/02/27 07:49:28]

Can we move the implementation to the cc file and DCHECK on profiles and
profileLoader?

[apiccion, 2013/02/28 01:31:04]

Done.

+                          IAuxiliaryProfileLoader* profileLoader)
+         : profiles_(*profiles), profileLoader_(*profileLoader) {}
+
+    void GetContactsProfile();
+
+ private:
+  string16 CollapseAddress(string16 pobox,
+                           string16 neighborhood);
+  void LoadAddress(AutofillProfile* profile);
+  void LoadName(AutofillProfile* profile);
+  void LoadEmailAddress(AutofillProfile* profile);
+  void LoadPhoneNumbers(AutofillProfile* profile);
+ private:

[David Trainor- moved to gerrit, 2013/02/27 07:49:28]

Don't need another private here

[apiccion, 2013/02/28 01:31:04]

Done.

+  ScopedVector<AutofillProfile>& profiles_;

[David Trainor- moved to gerrit, 2013/02/27 07:49:28]

Might make sense to just store pointers here but I don't think it matters.

[apiccion, 2013/02/28 01:31:04]

Done.

+  IAuxiliaryProfileLoader& profileLoader_;

[David Trainor- moved to gerrit, 2013/02/27 07:49:28]

I feel like this should be profile_loader_ but I forget if this form is also
valid.  Also applies to function parameter in constructor

[apiccion, 2013/02/28 01:31:04]

Style guide says must be lowercase with the extra underscore as optional. Fixed.
On 2013/02/27 07:49:28, David Trainor wrote:

+
+  DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfilesImpl);
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_