chrome/browser/autofill/auxiliary_profile_impl_android.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff: chrome/browser/autofill/auxiliary_profile_impl_android.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/android/chrome_jni_registrar.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/auxiliary_profile_impl_android.cc » ('j') | chrome/browser/autofill/auxiliary_profile_impl_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_

	7

	8 #include <jni.h>

	9 #include "base/guid.h"

	10 #include "base/logging.h"

	11 #include "base/memory/scoped_ptr.h"

	12 #include "base/memory/scoped_vector.h"

	13 #include "base/string16.h"

	14 #include "base/utf_string_conversions.h"

	15 #include "chrome/browser/autofill/autofill_profile.h"

	16 #include "chrome/browser/autofill/i_auxiliary_profile_loader.h"

	17

	18 class AuxiliaryProfilesImpl {
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Do we need Impl on this if there isn't an interfac Do we need Impl on this if there isn't an interface? Can we call this AuxiliaryProfilesAndroid? Make profile -> profiles in the file name. apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Do we need Impl on this if there isn't an interface? Can we call this > AuxiliaryProfilesAndroid? > > Make profile -> profiles in the file name. Done. apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Do we need Impl on this if there isn't an interface? Can we call this > AuxiliaryProfilesAndroid? > > Make profile -> profiles in the file name. Done.
	19 public:

	20 AuxiliaryProfilesImpl(ScopedVector<AutofillProfile>* profiles,
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Can we move the implementation to the cc file and Can we move the implementation to the cc file and DCHECK on profiles and profileLoader? apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Can we move the implementation to the cc file and DCHECK on profiles and > profileLoader? Done.
	21 IAuxiliaryProfileLoader* profileLoader)

	22 : profiles_(profiles), profileLoader_(profileLoader) {}

	23

	24 void GetContactsProfile();

	25

	26 private:

	27 string16 CollapseAddress(string16 pobox,

	28 string16 neighborhood);

	29 void LoadAddress(AutofillProfile* profile);

	30 void LoadName(AutofillProfile* profile);

	31 void LoadEmailAddress(AutofillProfile* profile);

	32 void LoadPhoneNumbers(AutofillProfile* profile);

	33 private:
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Don't need another private here Don't need another private here apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Don't need another private here Done.
	34 ScopedVector<AutofillProfile>& profiles_;
	David Trainor- moved to gerrit 2013/02/27 07:49:28 Might make sense to just store pointers here but I Might make sense to just store pointers here but I don't think it matters. apiccion 2013/02/28 01:31:04 Done. Show quoted text On 2013/02/27 07:49:28, David Trainor wrote: > Might make sense to just store pointers here but I don't think it matters. Done.
	35 IAuxiliaryProfileLoader& profileLoader_;
	David Trainor- moved to gerrit 2013/02/27 07:49:28 I feel like this should be profile_loader_ but I f I feel like this should be profile_loader_ but I forget if this form is also valid. Also applies to function parameter in constructor apiccion 2013/02/28 01:31:04 Style guide says must be lowercase with the extra Style guide says must be lowercase with the extra underscore as optional. Fixed. On 2013/02/27 07:49:28, David Trainor wrote: Show quoted text > I feel like this should be profile_loader_ but I forget if this form is also > valid. Also applies to function parameter in constructor
	36

	37 DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfilesImpl);

	38 };

	39

	40 #endif // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_IMPL_ANDROID_H_

OLD	NEW