Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 12279015: Mac Chromium style checker cleanup (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi
Modified:
7 years, 10 months ago
CC:
chromium-reviews, asanka, penghuang+watch_chromium.org, yusukes+watch_chromium.org, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, rpetterson, jam, rouslan+spellwatch_chromium.org, sail+watch_chromium.org, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, Aaron Boodman, rsesek+watch_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, James Su
Visibility:
Public.

Description

Mac Chromium style checker cleanup Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=brettw, scherkus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183469

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -135 lines) Patch
M chrome/app/breakpad_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/speech/tts_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +17 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_started_animation_mac.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller_unittest.mm View 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm View 1 chunk +17 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.mm View 1 chunk +5 lines, -5 lines 1 comment Download
M chrome/browser/ui/cocoa/speech_recognition_bubble_cocoa.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/multi_process_lock_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mach_broker_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac_system_access_unittest.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/external_popup_menu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M rlz/lib/financial_ping.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/surface/io_surface_support_mac.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Sleevi
thakis: Since you're conveniently an owner of chrome/, rlz/ and ui/, would you kindly?
7 years, 10 months ago (2013-02-15 22:20:12 UTC) #1
Nico
lgtm https://codereview.chromium.org/12279015/diff/1/chrome/browser/ui/cocoa/profile_menu_controller.mm File chrome/browser/ui/cocoa/profile_menu_controller.mm (right): https://codereview.chromium.org/12279015/diff/1/chrome/browser/ui/cocoa/profile_menu_controller.mm#newcode43 chrome/browser/ui/cocoa/profile_menu_controller.mm:43: virtual void OnBrowserAdded(Browser* browser) OVERRIDE {} Once OVERRIDE ...
7 years, 10 months ago (2013-02-18 10:43:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12279015/1
7 years, 10 months ago (2013-02-18 10:44:03 UTC) #3
commit-bot: I haz the power
Presubmit check for 12279015-1 failed and returned exit status 1. INFO:root:Found 44 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-18 10:44:29 UTC) #4
Ryan Sleevi
brettw, scherkus: TBR for the minor changes to content/ and media/ respectively.
7 years, 10 months ago (2013-02-19 23:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12279015/1
7 years, 10 months ago (2013-02-19 23:28:17 UTC) #6
scherkus (not reviewing)
lgtm
7 years, 10 months ago (2013-02-19 23:37:01 UTC) #7
brettw
LGTM rubberstamp
7 years, 10 months ago (2013-02-19 23:45:15 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 11:16:24 UTC) #9
Message was sent while issue was closed.
Change committed as 183469

Powered by Google App Engine
This is Rietveld 408576698