chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 12279015: Mac Chromium style checker cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 12279015: Mac Chromium style checker cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | chrome/browser/ui/cocoa/profile_menu_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 73e0af3f57330861daeba2a123d83aefa6cc4fdf..94701dc654de8adc93f3a0f058062d1278ba63d9 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -67,9 +67,10 @@ class ExtensionLoadedNotificationObserver

private:

// NotificationObserver implementation. Tells the controller to start showing

// its window on the main thread when the extension has finished loading.

- void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) {

+ virtual void Observe(

+ int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) OVERRIDE {

if (type == chrome::NOTIFICATION_EXTENSION_LOADED) {

const Extension* extension =

content::Details<const Extension>(details).ptr();