Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 12264002: Use "chrome://settings/search#Users" instead of "chrome://settings" (Closed)

Created:
7 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Use "chrome://settings/search#Users" instead of "chrome://settings" when the user choose to create a new user from the sign in confirmation dialog. BUG=175541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182510

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Drew, Can you please take a look? Thanks.
7 years, 10 months ago (2013-02-13 16:11:13 UTC) #1
Andrew T Wilson (Slow)
LGTM with one change. https://codereview.chromium.org/12264002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/12264002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode174 chrome/browser/ui/sync/one_click_signin_helper.cc:174: chrome::ShowSettingsSubPage(args.browser, std::string("search#Users")); Instead of hard-coding ...
7 years, 10 months ago (2013-02-13 20:43:10 UTC) #2
Roger Tawa OOO till Jul 10th
Thanks Drew. Changes uploaded. https://codereview.chromium.org/12264002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/12264002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode174 chrome/browser/ui/sync/one_click_signin_helper.cc:174: chrome::ShowSettingsSubPage(args.browser, std::string("search#Users")); On 2013/02/13 20:43:10, ...
7 years, 10 months ago (2013-02-14 15:39:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/12264002/8001
7 years, 10 months ago (2013-02-14 15:39:59 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 19:26:26 UTC) #5
Message was sent while issue was closed.
Change committed as 182510

Powered by Google App Engine
This is Rietveld 408576698