Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 12264002: Use "chrome://settings/search#Users" instead of "chrome://settings" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 90b0f3be5c68e5db1139c945060b91b06fd2de50..692331f774339cc7646f50294b1df7786c3cc96c 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -171,7 +171,8 @@ void StartExplicitSync(const StartSyncArgs& args,
contents->GetController().LoadURL(
GURL(chrome::kChromeUINewTabURL), content::Referrer(),
content::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string());
- chrome::ShowSettings(args.browser);
+ chrome::ShowSettingsSubPage(args.browser,
+ std::string(chrome::kSearchUsersSubPage));
} else {
StartSync(args, start_mode);
}
@@ -1053,8 +1054,8 @@ void OneClickSigninHelper::DidStopLoading(
break;
case AUTO_ACCEPT_EXPLICIT: {
OneClickSigninSyncStarter::StartSyncMode start_mode =
- source_ == SyncPromoUI::SOURCE_SETTINGS ?
- OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST :
+ source_ == SyncPromoUI::SOURCE_SETTINGS ?
+ OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST :
OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS;
// If the new email address is different from the email address that
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698