Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 12259017: Maintain Android strings in grd files. (Closed)

Created:
7 years, 10 months ago by newt (away)
Modified:
7 years, 9 months ago
Reviewers:
Ted C, cjhopman, nyquist
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Maintain Android strings in grd files. This removes the Android/Java strings.xml files, which are now generated at build time from grd files. New strings should now be added to the grd files. BUG=167248 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185218

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix behavior for targets that don't generate strings.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -96 lines) Patch
M build/android/process_resources.py View 1 2 3 chunks +18 lines, -13 lines 0 comments Download
M build/java.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/strings.xml View 1 chunk +6 lines, -31 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/java/res/values/strings.xml View 1 chunk +6 lines, -43 lines 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/android/java/res/values/strings.xml View 1 chunk +9 lines, -8 lines 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
newt (away)
PTAL. This is not *quite* as trivial as I hoped, but it's close.
7 years, 10 months ago (2013-02-14 00:50:32 UTC) #1
newt (away)
ping?
7 years, 10 months ago (2013-02-19 22:49:20 UTC) #2
cjhopman
lgtm https://codereview.chromium.org/12259017/diff/1/build/android/process_resources.py File build/android/process_resources.py (right): https://codereview.chromium.org/12259017/diff/1/build/android/process_resources.py#newcode66 build/android/process_resources.py:66: '--auto-add-overlay', what's --auto-add-overlay?
7 years, 10 months ago (2013-02-19 22:57:15 UTC) #3
newt (away)
https://codereview.chromium.org/12259017/diff/1/build/android/process_resources.py File build/android/process_resources.py (right): https://codereview.chromium.org/12259017/diff/1/build/android/process_resources.py#newcode66 build/android/process_resources.py:66: '--auto-add-overlay', On 2013/02/19 22:57:15, cjhopman wrote: > what's --auto-add-overlay? ...
7 years, 10 months ago (2013-02-20 01:19:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12259017/1
7 years, 10 months ago (2013-02-20 01:20:49 UTC) #5
commit-bot: I haz the power
Presubmit check for 12259017-1 failed and returned exit status 1. INFO:root:Found 8 file(s). INFO:PRESUBMIT:Skipping pylint: ...
7 years, 10 months ago (2013-02-20 01:20:56 UTC) #6
newt (away)
+tedchoc for owner goodness
7 years, 10 months ago (2013-02-20 01:28:32 UTC) #7
Ted C
On 2013/02/20 01:28:32, newt wrote: > +tedchoc for owner goodness lgtm I would like those ...
7 years, 10 months ago (2013-02-20 01:37:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12259017/1
7 years, 10 months ago (2013-02-20 01:40:27 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-20 09:56:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12259017/22001
7 years, 9 months ago (2013-02-28 08:52:30 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 11:05:59 UTC) #12
Message was sent while issue was closed.
Change committed as 185218

Powered by Google App Engine
This is Rietveld 408576698