Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 12258047: [content shell] Use the TestRunner library again and remove the mock testRunner (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] Use the TestRunner library again and remove the mock testRunner BUG=111316, 173079 TEST=content_browsertests still work, almost all layout tests pass R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -411 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/shell_content_renderer_client.h View 3 chunks +7 lines, -1 line 0 comments Download
M content/shell/shell_content_renderer_client.cc View 3 chunks +26 lines, -36 lines 0 comments Download
M content/shell/shell_render_process_observer.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M content/shell/shell_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/webkit_test_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/webkit_test_runner.h View 4 chunks +3 lines, -17 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 10 chunks +62 lines, -191 lines 0 comments Download
D content/shell/webkit_test_runner_bindings.h View 1 chunk +0 lines, -29 lines 0 comments Download
D content/shell/webkit_test_runner_bindings.cc View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-15 08:04:00 UTC) #1
marja
lgtm
7 years, 10 months ago (2013-02-15 09:19:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12258047/1
7 years, 10 months ago (2013-02-15 16:32:08 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 19:48:21 UTC) #4
Message was sent while issue was closed.
Change committed as 182794

Powered by Google App Engine
This is Rietveld 408576698