Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/shell/webkit_test_runner.h

Issue 12258047: [content shell] Use the TestRunner library again and remove the mock testRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/webkit_test_controller.cc ('k') | content/shell/webkit_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/webkit_test_runner.h
diff --git a/content/shell/webkit_test_runner.h b/content/shell/webkit_test_runner.h
index ed6c7707857de8ff0acb7cc3da35ef3b36eef5fa..f5260121ff7a3134f2a9ca79549d769bfdaf1b11 100644
--- a/content/shell/webkit_test_runner.h
+++ b/content/shell/webkit_test_runner.h
@@ -34,7 +34,6 @@ class WebKitTestRunner : public RenderViewObserver,
// RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void DidClearWindowObject(WebKit::WebFrame* frame) OVERRIDE;
- virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
// WebTestDelegate implementation.
virtual void clearEditCommand();
@@ -106,15 +105,9 @@ class WebKitTestRunner : public RenderViewObserver,
size_t* currentEntryIndex);
void Reset();
- void NotifyDone();
- void DumpAsText();
- void DumpChildFramesAsText();
- void WaitUntilDone();
- void OverridePreference(const std::string& key, v8::Local<v8::Value> value);
-
- void NotImplemented(const std::string& object, const std::string& method);
void set_proxy(::WebTestRunner::WebTestProxyBase* proxy) { proxy_ = proxy; }
+ ::WebTestRunner::WebTestProxyBase* proxy() const { return proxy_; }
private:
// Message handlers.
@@ -126,8 +119,6 @@ class WebKitTestRunner : public RenderViewObserver,
const std::string& expected_pixel_hash);
void CaptureDump();
- void CaptureTextDump();
- void CaptureImageDump();
static int window_count_;
@@ -137,18 +128,13 @@ class WebKitTestRunner : public RenderViewObserver,
::WebTestRunner::WebPreferences prefs_;
- bool test_is_running_;
- bool wait_until_done_;
- bool load_finished_;
- bool dump_as_text_;
- bool dump_child_frames_as_text_;
- bool printing_;
-
bool enable_pixel_dumping_;
int layout_test_timeout_;
bool allow_external_pages_;
std::string expected_pixel_hash_;
+ bool is_main_window_;
+
DISALLOW_COPY_AND_ASSIGN(WebKitTestRunner);
};
« no previous file with comments | « content/shell/webkit_test_controller.cc ('k') | content/shell/webkit_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698