Issue 12257002: [Cleanup] Files.app: Remove 'this' from class methods. #1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12257002: [Cleanup] Files.app: Remove 'this' from class methods. #1 (Closed)

Created:
7 years, 10 months ago by yoshiki

Modified:
7 years, 10 months ago

Reviewers:

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Cleanup] Files.app: Remove 'this' from class methods. #1 In class method (not instance methods), we shouldn't use this because 'this' indicates not "instance" but "class" itself. BUG=175657 TEST=Files.app launches. TBR=mtomasz@chromium.org, haruki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182222

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -43 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_grid.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_pyauto.js	View	14 chunks	+24 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/harness.js	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/util.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12257002/1

7 years, 10 months ago (2013-02-13 12:55:09 UTC) #1

Message was sent while issue was closed.

Change committed as 182222