Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager_pyauto.js

Issue 12257002: [Cleanup] Files.app: Remove 'this' from class methods. #1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager_pyauto.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager_pyauto.js b/chrome/browser/resources/file_manager/js/file_manager_pyauto.js
index 45eaa2d939ece3d7c9ab0d0ea23ae39adb8e287f..c420a78016a088fa4ae411be9f0b98a1f6c8127b 100644
--- a/chrome/browser/resources/file_manager/js/file_manager_pyauto.js
+++ b/chrome/browser/resources/file_manager/js/file_manager_pyauto.js
@@ -28,7 +28,7 @@ var pyautoAPI = {
break;
}
}
- this.sendValue_(entryExists);
+ pyautoAPI.sendValue_(entryExists);
},
/**
@@ -41,7 +41,7 @@ var pyautoAPI = {
for (var i = 0; i < dm.length; i++) {
list.push(dm.item(i).name);
}
- this.sendJSONValue_(list);
+ pyautoAPI.sendJSONValue_(list);
},
/**
@@ -56,7 +56,7 @@ var pyautoAPI = {
} else {
throw new Error('Cannot save an item in this dialog type.');
}
- this.sendDone_();
+ pyautoAPI.sendDone_();
},
/**
@@ -72,7 +72,7 @@ var pyautoAPI = {
default:
throw new Error('Cannot open an item in this dialog type.');
}
- this.sendDone_();
+ pyautoAPI.sendDone_();
},
/**
@@ -89,7 +89,7 @@ var pyautoAPI = {
default:
throw new Error('Cannot execute a task in this dialog type.');
}
- this.sendDone_();
+ pyautoAPI.sendDone_();
},
/**
@@ -107,16 +107,16 @@ var pyautoAPI = {
* Copy selected items to clipboard.
*/
copyItems: function() {
- this.executeClipboardCommand_('copy');
- this.sendDone_();
+ pyautoAPI.executeClipboardCommand_('copy');
+ pyautoAPI.sendDone_();
},
/**
* Cut selected items to clipboard.
*/
cutItems: function() {
- this.executeClipboardCommand_('cut');
- this.sendDone_();
+ pyautoAPI.executeClipboardCommand_('cut');
+ pyautoAPI.sendDone_();
},
/**
@@ -126,11 +126,11 @@ var pyautoAPI = {
var dm = fileManager.directoryModel_;
var onRescan = function() {
dm.removeEventListener('rescan-completed', onRescan);
- this.sendDone_();
- }.bind(this);
+ pyautoAPI.sendDone_();
+ };
dm.addEventListener('rescan-completed', onRescan);
- this.executeClipboardCommand_('paste');
+ pyautoAPI.executeClipboardCommand_('paste');
},
/**
@@ -139,8 +139,8 @@ var pyautoAPI = {
*/
renameItem: function(name) {
var entry = fileManager.getSelection().entries[0];
- fileManager.directoryModel_.renameEntry(entry, name, this.sendDone_,
- this.sendDone_);
+ fileManager.directoryModel_.renameEntry(entry, name, pyautoAPI.sendDone_,
+ pyautoAPI.sendDone_);
},
/**
@@ -150,8 +150,8 @@ var pyautoAPI = {
var dm = fileManager.directoryModel_;
var onRescan = function() {
dm.removeEventListener('rescan-completed', onRescan);
- this.sendDone_();
- }.bind(this);
+ pyautoAPI.sendDone_();
+ };
dm.addEventListener('rescan-completed', onRescan);
fileManager.deleteSelection();
@@ -165,8 +165,8 @@ var pyautoAPI = {
var dm = fileManager.directoryModel_;
var onRescan = function() {
dm.removeEventListener('rescan-completed', onRescan);
- this.sendDone_();
- }.bind(this);
+ pyautoAPI.sendDone_();
+ };
dm.addEventListener('rescan-completed', onRescan);
fileManager.directoryModel_.createDirectory(name, function() {});
@@ -185,8 +185,8 @@ var pyautoAPI = {
var onChanged = function() {
dm.removeEventListener('directory-changed', onChanged);
- this.sendDone_();
- }.bind(this);
+ pyautoAPI.sendDone_();
+ };
dm.addEventListener('directory-changed', onChanged);
dm.changeDirectory(path);
@@ -196,7 +196,7 @@ var pyautoAPI = {
* Get the absolute path of current directory.
*/
currentDirectory: function() {
- this.sendValue_(fileManager.getCurrentDirectory());
+ pyautoAPI.sendValue_(fileManager.getCurrentDirectory());
},
/**
@@ -205,8 +205,8 @@ var pyautoAPI = {
getSelectedDirectorySizeStats: function() {
var directoryURL = fileManager.getSelection().entries[0].toURL();
chrome.fileBrowserPrivate.getSizeStats(directoryURL, function(stats) {
- this.sendJSONValue_(stats);
- }.bind(this));
+ pyautoAPI.sendJSONValue_(stats);
+ });
},
/**
@@ -218,7 +218,7 @@ var pyautoAPI = {
var initialized = fileManager &&
fileManager.workerInitialized_ &&
fileManager.getCurrentDirectory();
- this.sendValue_(!!initialized);
+ pyautoAPI.sendValue_(!!initialized);
},
/**
« no previous file with comments | « chrome/browser/resources/file_manager/js/file_grid.js ('k') | chrome/browser/resources/file_manager/js/harness.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698