Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3173)

Unified Diff: chrome/browser/instant/instant_service_factory.h

Issue 12256029: Use scoped_ptr to document ownership in InstantUnloadHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More correct ownership semantics Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_service.cc ('k') | chrome/browser/instant/instant_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_service_factory.h
diff --git a/chrome/browser/instant/instant_service_factory.h b/chrome/browser/instant/instant_service_factory.h
index 5e40af5a8c57d8fd6c33675b4fb057d5874b3aca..7fe041525d443e8a6e7d67d3be38110c006cf378 100644
--- a/chrome/browser/instant/instant_service_factory.h
+++ b/chrome/browser/instant/instant_service_factory.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_INSTANT_INSTANT_SERVICE_FACTORY_H_
#include "base/basictypes.h"
+#include "base/compiler_specific.h"
#include "base/memory/singleton.h"
#include "chrome/browser/profiles/profile_keyed_service_factory.h"
@@ -13,8 +14,7 @@ class InstantService;
class Profile;
class ProfileKeyedService;
-// Singleton that owns all InstantServices and associates them with
-// Profiles.
+// Singleton that owns all InstantServices and associates them with Profiles.
class InstantServiceFactory : public ProfileKeyedServiceFactory {
public:
// Returns the InstantService for |profile|.
@@ -22,15 +22,13 @@ class InstantServiceFactory : public ProfileKeyedServiceFactory {
static InstantServiceFactory* GetInstance();
- static ProfileKeyedService* BuildInstanceFor(Profile* profile);
-
private:
friend struct DefaultSingletonTraits<InstantServiceFactory>;
InstantServiceFactory();
virtual ~InstantServiceFactory();
- // ProfileKeyedServiceFactory:
+ // Overridden from ProfileKeyedServiceFactory:
virtual bool ServiceRedirectedInIncognito() const OVERRIDE;
virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;
virtual ProfileKeyedService* BuildServiceInstanceFor(
« no previous file with comments | « chrome/browser/instant/instant_service.cc ('k') | chrome/browser/instant/instant_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698