Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5508)

Unified Diff: chrome/browser/instant/instant_service_factory.cc

Issue 12256029: Use scoped_ptr to document ownership in InstantUnloadHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More correct ownership semantics Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_service_factory.h ('k') | chrome/browser/instant/instant_unload_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_service_factory.cc
diff --git a/chrome/browser/instant/instant_service_factory.cc b/chrome/browser/instant/instant_service_factory.cc
index d17a235082e39aebf05c27d7703b4af44c934321..6fdaccf99fa42e18d20820e68251c2b9ce69b818 100644
--- a/chrome/browser/instant/instant_service_factory.cc
+++ b/chrome/browser/instant/instant_service_factory.cc
@@ -18,11 +18,6 @@ InstantServiceFactory* InstantServiceFactory::GetInstance() {
return Singleton<InstantServiceFactory>::get();
}
-// static
-ProfileKeyedService* InstantServiceFactory::BuildInstanceFor(Profile* profile) {
- return new InstantService;
-}
-
InstantServiceFactory::InstantServiceFactory()
: ProfileKeyedServiceFactory("InstantService",
ProfileDependencyManager::GetInstance()) {
@@ -42,5 +37,5 @@ bool InstantServiceFactory::ServiceIsNULLWhileTesting() const {
ProfileKeyedService* InstantServiceFactory::BuildServiceInstanceFor(
Profile* profile) const {
- return BuildInstanceFor(profile);
+ return new InstantService;
}
« no previous file with comments | « chrome/browser/instant/instant_service_factory.h ('k') | chrome/browser/instant/instant_unload_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698