chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 12253022: Manifest handler for all keys background-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/file_handlers/file_handlers_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index a33e7cfefb0bf3d1d3a544deed60892797587773..7acf586364a4a3f47deb579104480eaec43b106c 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -27,8 +27,6 @@

#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"

#include "chrome/common/extensions/api/extension_action/page_action_handler.h"

#include "chrome/common/extensions/api/extension_action/script_badge_handler.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

-#include "chrome/common/extensions/manifest_handler.h"

#include "chrome/common/render_messages.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_service.h"

@@ -189,15 +187,9 @@ static base::LazyInstance<ProfileKeyedAPIFactory<ExtensionActionAPI> >

g_factory = LAZY_INSTANCE_INITIALIZER;

ExtensionActionAPI::ExtensionActionAPI(Profile* profile) {

- ManifestHandler::Register(extension_manifest_keys::kBrowserAction,

- make_linked_ptr(new BrowserActionHandler));

- linked_ptr<PageActionHandler> page_action_handler(new PageActionHandler);

- ManifestHandler::Register(

- extension_manifest_keys::kPageAction, page_action_handler);

- ManifestHandler::Register(

- extension_manifest_keys::kPageActions, page_action_handler);

- ManifestHandler::Register(extension_manifest_keys::kScriptBadge,

- make_linked_ptr(new ScriptBadgeHandler));

+ (new BrowserActionHandler)->Register();

+ (new PageActionHandler)->Register();

+ (new ScriptBadgeHandler)->Register();

ExtensionFunctionRegistry* registry =

ExtensionFunctionRegistry::GetInstance();