chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 12253022: Manifest handler for all keys background-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/context_menus/context_menus_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 8f48d4298648ce55fccb1eaa3fca55eb3cfda160..3d71e1912b0da2bcbb774b4c0e36c5ad053675c5 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -28,6 +28,7 @@

#include "chrome/browser/view_type_utils.h"

#include "chrome/common/extensions/api/developer_private.h"

#include "chrome/common/extensions/api/icons/icons_handler.h"

+#include "chrome/common/extensions/background_info.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_resource.h"

#include "chrome/common/extensions/manifest_url_handler.h"

@@ -302,10 +303,11 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::

GetShellWindowPagesForExtensionProfile(extension, &result);

// Include a link to start the lazy background page, if applicable.

- if (extension->has_lazy_background_page() && extension_is_enabled &&

+ if (BackgroundInfo::HasLazyBackgroundPage(extension) &&

+ extension_is_enabled &&

!process_manager->GetBackgroundHostForExtension(extension->id())) {

- result.push_back(

- constructInspectView(extension->GetBackgroundURL(), -1, -1, false));

+ result.push_back(constructInspectView(

+ BackgroundInfo::GetBackgroundURL(extension), -1, -1, false));

}

ExtensionService* service = profile()->GetExtensionService();

@@ -319,10 +321,11 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::

process_manager->GetRenderViewHostsForExtension(extension->id()),

&result);