Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 12252020: Add a telemetry-based gpu_tests folder (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Add a telemetry-based gpu_tests folder BUG=143317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183915

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -15 lines) Patch
A + content/test/gpu/gpu_tests/__init__.py View 1 chunk +3 lines, -2 lines 0 comments Download
A + content/test/gpu/gpu_tests/bootstrap_deps View 1 chunk +5 lines, -5 lines 0 comments Download
A content/test/gpu/gpu_tests/pixel_test.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + content/test/gpu/page_sets/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/gpu/page_sets/pixel_tests.json View 1 chunk +10 lines, -0 lines 0 comments Download
A + content/test/gpu/run_gpu_tests View 1 2 chunks +12 lines, -8 lines 0 comments Download
M tools/perf/run_multipage_benchmarks View 1 1 chunk +1 line, -1 line 0 comments Download
A tools/telemetry/telemetry/page/page_test_runner.py View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nduca
ptal
7 years, 10 months ago (2013-02-13 22:09:15 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. Thanks for putting this infrastructure in place. https://codereview.chromium.org/12252020/diff/1/content/test/gpu/page_sets/pixel_tests.json File content/test/gpu/page_sets/pixel_tests.json (right): https://codereview.chromium.org/12252020/diff/1/content/test/gpu/page_sets/pixel_tests.json#newcode6 content/test/gpu/page_sets/pixel_tests.json:6: "url": ...
7 years, 10 months ago (2013-02-13 22:15:40 UTC) #2
nduca
Note, I have filed crbug.com/176139 to unify page_test_runner with the erstwhile multipage_benchmark_runner.
7 years, 10 months ago (2013-02-13 22:45:33 UTC) #3
dtu
https://chromiumcodereview.appspot.com/12252020/diff/1/content/test/gpu/page_sets/__init__.py File content/test/gpu/page_sets/__init__.py (right): https://chromiumcodereview.appspot.com/12252020/diff/1/content/test/gpu/page_sets/__init__.py#newcode1 content/test/gpu/page_sets/__init__.py:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 10 months ago (2013-02-13 23:54:23 UTC) #4
nduca
Most changes made, but page discovery still left as a copy. I dont think it ...
7 years, 10 months ago (2013-02-20 05:03:13 UTC) #5
nduca
@dtu, ping
7 years, 10 months ago (2013-02-21 04:43:11 UTC) #6
dtu
lgtm
7 years, 10 months ago (2013-02-21 05:12:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12252020/8001
7 years, 10 months ago (2013-02-21 05:18:04 UTC) #8
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) build http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=21402
7 years, 10 months ago (2013-02-21 08:09:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12252020/8001
7 years, 10 months ago (2013-02-21 23:46:19 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 00:05:16 UTC) #11
Message was sent while issue was closed.
Change committed as 183915

Powered by Google App Engine
This is Rietveld 408576698