Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 12248003: Add a null check for the target node in page_click_tracker. (Closed)

Created:
7 years, 10 months ago by Stephen Chennney
Modified:
7 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add a null check for the target node in page_click_tracker. Events arising from clicks on instance elements in SVG <use> trees may have their target changed when the instance tree is rebuilt during event processing. In this case the toNode() call will return NULL for the target. BUG=171363 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/renderer/page_click_tracker.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Stephen Chennney
7 years, 10 months ago (2013-02-11 23:35:07 UTC) #1
csharp
lgtm
7 years, 10 months ago (2013-02-12 14:14:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/12248003/1
7 years, 10 months ago (2013-02-12 15:26:39 UTC) #3
commit-bot: I haz the power
Presubmit check for 12248003-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-12 15:26:42 UTC) #4
jam
rubberstamp lgtm
7 years, 10 months ago (2013-02-12 17:50:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/12248003/1
7 years, 10 months ago (2013-02-12 18:16:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110868
7 years, 10 months ago (2013-02-12 20:34:58 UTC) #7
Stephen Chennney
On 2013/02/12 20:34:58, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 10 months ago (2013-02-12 21:15:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/12248003/1
7 years, 10 months ago (2013-02-12 21:16:35 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 23:03:13 UTC) #10
Message was sent while issue was closed.
Change committed as 182049

Powered by Google App Engine
This is Rietveld 408576698