Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9395)

Unified Diff: chrome/renderer/page_click_tracker.cc

Issue 12248003: Add a null check for the target node in page_click_tracker. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/page_click_tracker.cc
===================================================================
--- chrome/renderer/page_click_tracker.cc (revision 181734)
+++ chrome/renderer/page_click_tracker.cc (working copy)
@@ -132,6 +132,10 @@
// We'll get a notification once the mouse event has been processed
// (DidHandleMouseEvent), we'll notify the listener at that point.
WebNode node = mouse_event.target();
+ if (node.isNull())
+ // Node may be null if the target was an SVG instance element from a <use>
+ // tree and the tree has been rebuilt due to an earlier event.
+ return;
HandleTextFieldMaybeLosingFocus(node);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698