Issue 12226090: Order arguments of ComputeMonomorphicFlags to match ComputeFlags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226090: Order arguments of ComputeMonomorphicFlags to match ComputeFlags. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Order arguments of ComputeMonomorphicFlags to match ComputeFlags. Committed: https://code.google.com/p/v8/source/detail?r=13769

Patch Set 2 : Addressed comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -61 lines)			Patch
M	src/objects.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/stub-cache.cc	View		26 chunks	+44 lines, -48 lines	0 comments	Download
M	src/type-info.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. https://chromiumcodereview.appspot.com/12226090/diff/1/src/type-info.cc File src/type-info.cc (right): https://chromiumcodereview.appspot.com/12226090/diff/1/src/type-info.cc#newcode220 src/type-info.cc:220: Code::ComputeMonomorphicFlags(Code::LOAD_IC, Code::NORMAL); Missed one here. https://chromiumcodereview.appspot.com/12226090/diff/1/src/type-info.cc#newcode229 ...

7 years, 10 months ago (2013-02-11 14:47:28 UTC) #2

Toon Verwaest

7 years, 9 months ago (2013-02-27 15:33:43 UTC) #4

Message was sent while issue was closed.

Committed manually as r13769 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12226090: Order arguments of ComputeMonomorphicFlags to match ComputeFlags. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages