Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects-inl.h

Issue 12226090: Order arguments of ComputeMonomorphicFlags to match ComputeFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3777 matching lines...) Expand 10 before | Expand all | Expand 10 after
3788 | ICStateField::encode(ic_state) 3788 | ICStateField::encode(ic_state)
3789 | TypeField::encode(type) 3789 | TypeField::encode(type)
3790 | ExtraICStateField::encode(extra_ic_state) 3790 | ExtraICStateField::encode(extra_ic_state)
3791 | (argc << kArgumentsCountShift) 3791 | (argc << kArgumentsCountShift)
3792 | CacheHolderField::encode(holder); 3792 | CacheHolderField::encode(holder);
3793 return static_cast<Flags>(bits); 3793 return static_cast<Flags>(bits);
3794 } 3794 }
3795 3795
3796 3796
3797 Code::Flags Code::ComputeMonomorphicFlags(Kind kind, 3797 Code::Flags Code::ComputeMonomorphicFlags(Kind kind,
3798 ExtraICState extra_ic_state,
3798 StubType type, 3799 StubType type,
3799 ExtraICState extra_ic_state, 3800 int argc,
3800 InlineCacheHolderFlag holder, 3801 InlineCacheHolderFlag holder) {
3801 int argc) {
3802 return ComputeFlags(kind, MONOMORPHIC, extra_ic_state, type, argc, holder); 3802 return ComputeFlags(kind, MONOMORPHIC, extra_ic_state, type, argc, holder);
3803 } 3803 }
3804 3804
3805 3805
3806 Code::Kind Code::ExtractKindFromFlags(Flags flags) { 3806 Code::Kind Code::ExtractKindFromFlags(Flags flags) {
3807 return KindField::decode(flags); 3807 return KindField::decode(flags);
3808 } 3808 }
3809 3809
3810 3810
3811 InlineCacheState Code::ExtractICStateFromFlags(Flags flags) { 3811 InlineCacheState Code::ExtractICStateFromFlags(Flags flags) {
(...skipping 2078 matching lines...) Expand 10 before | Expand all | Expand 10 after
5890 #undef WRITE_UINT32_FIELD 5890 #undef WRITE_UINT32_FIELD
5891 #undef READ_SHORT_FIELD 5891 #undef READ_SHORT_FIELD
5892 #undef WRITE_SHORT_FIELD 5892 #undef WRITE_SHORT_FIELD
5893 #undef READ_BYTE_FIELD 5893 #undef READ_BYTE_FIELD
5894 #undef WRITE_BYTE_FIELD 5894 #undef WRITE_BYTE_FIELD
5895 5895
5896 5896
5897 } } // namespace v8::internal 5897 } } // namespace v8::internal
5898 5898
5899 #endif // V8_OBJECTS_INL_H_ 5899 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698