<webview>: Store <webview> embedder info in ExtensionRendererState

<webview>: Store <webview> embedder info in ExtensionRendererState

In order to support WebRequest event listeners that are valid for the lifetime
of the <webview>, rather than for the lifetime of a particular guest RenderView,
we need to carry information about the <webview> embedder in
ExtensionRendererState.

Lifetimes of the guest and the container <webview> are not identical for the
following reasons:

1. A <webview> does not create a guest RenderView until it performs its first
   navigation.
2. A guest render process may crash but the <webview> can recover from that by
   spawning off a new guest render process.

Thus, we would like WebRequest API event listeners to outlast guests and survive
for the lifetime of the <webview>.

BUG=171421
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181231

[Fady Samuel, 2013-02-05 23:43:21]

mpcomplete@: extension_renderer_state and web_request_api changes
jam@: public content API changes

[jam, 2013-02-06 17:02:09]

https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
content/public/browser/web_contents.h:155: virtual int GetInstanceID() const =
0;
why does this need to be exposed? i don't see it used in the current cl

[Fady Samuel, 2013-02-06 17:06:00]

https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
content/public/browser/web_contents.h:155: virtual int GetInstanceID() const =
0;
On 2013/02/06 17:02:09, jam wrote:
> why does this need to be exposed? i don't see it used in the current cl

It is, see in ExtensionRendererState

web_view_info.web_view_instance_id = web_contents->GetInstanceID();

[Matt Perry, 2013-02-06 22:06:54]

lgtm

https://codereview.chromium.org/12226022/diff/5001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_renderer_state.h (right):

https://codereview.chromium.org/12226022/diff/5001/chrome/browser/extensions/...
chrome/browser/extensions/extension_renderer_state.h:34: bool GetWebViewInfo(int
render_process_host_id, int routing_id,
Can you rename these guest_render_process_id and guest_routing_id? It wasn't
clear to me which process they referred to.

https://codereview.chromium.org/12226022/diff/5001/content/public/browser/web...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/12226022/diff/5001/content/public/browser/web...
content/public/browser/web_contents.h:155: virtual int GetInstanceID() const =
0;
GetEmbeddedInstanceId?

[jam, 2013-02-06 22:13:05]

On 2013/02/06 17:06:00, Fady Samuel wrote:
>
https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
> File content/public/browser/web_contents.h (right):
> 
>
https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
> content/public/browser/web_contents.h:155: virtual int GetInstanceID() const =
> 0;
> On 2013/02/06 17:02:09, jam wrote:
> > why does this need to be exposed? i don't see it used in the current cl
> 
> It is, see in ExtensionRendererState
> 
> web_view_info.web_view_instance_id = web_contents->GetInstanceID();

right, but web_view_instance_id isn't used anywhere.

[Fady Samuel, 2013-02-06 22:14:15]

On 2013/02/06 22:13:05, jam wrote:
> On 2013/02/06 17:06:00, Fady Samuel wrote:
> >
>
https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
> > File content/public/browser/web_contents.h (right):
> > 
> >
>
https://codereview.chromium.org/12226022/diff/1/content/public/browser/web_co...
> > content/public/browser/web_contents.h:155: virtual int GetInstanceID() const
=
> > 0;
> > On 2013/02/06 17:02:09, jam wrote:
> > > why does this need to be exposed? i don't see it used in the current cl
> > 
> > It is, see in ExtensionRendererState
> > 
> > web_view_info.web_view_instance_id = web_contents->GetInstanceID();
> 
> right, but web_view_instance_id isn't used anywhere.

Used by a subsequent CL here: https://chromiumcodereview.appspot.com/12189018/

[Fady Samuel, 2013-02-06 23:23:33]

Fixed nits.

https://codereview.chromium.org/12226022/diff/5001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_renderer_state.h (right):

https://codereview.chromium.org/12226022/diff/5001/chrome/browser/extensions/...
chrome/browser/extensions/extension_renderer_state.h:34: bool GetWebViewInfo(int
render_process_host_id, int routing_id,
On 2013/02/06 22:06:55, Matt Perry wrote:
> Can you rename these guest_render_process_id and guest_routing_id? It wasn't
> clear to me which process they referred to.

Done.

https://codereview.chromium.org/12226022/diff/5001/content/public/browser/web...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/12226022/diff/5001/content/public/browser/web...
content/public/browser/web_contents.h:155: virtual int GetInstanceID() const =
0;
On 2013/02/06 22:06:55, Matt Perry wrote:
> GetEmbeddedInstanceId?

Done.

[jam, 2013-02-06 23:37:46]

> Used by a subsequent CL here: https://chromiumcodereview.appspot.com/12189018/



i see, ok lgtm. document what instance id means though, as that's a new concept
in the content api

[commit-bot: I haz the power, 2013-02-07 00:19:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/12226022/1007

[commit-bot: I haz the power, 2013-02-07 06:17:04]

Change committed as 181231