Move bitmap manipulation functions in bitmap.h

Move bitmap manipulation functions in bitmap.h

This makes it clear that we don't use "dark validator internals" in
dfa_validate_32.c/dfa_validate_64.c

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3167
TEST=trybots (no changes in functionality)
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10727

[halyavin, 2013-02-06 02:30:08]

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
File src/trusted/validator_ragel/bitmap.h (right):

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/bitmap.h:31: sizeof *bitmap;
Please, add brackets around *bitmap.

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/bitmap.h:32: bitmap = malloc(byte_count);
We can use calloc and move sizeof here.

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (left):

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_32.gyp:11: 'target_defaults': {
Is it needed for this CL?

[khim, 2013-02-06 08:01:49]

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
File src/trusted/validator_ragel/bitmap.h (right):

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/bitmap.h:31: sizeof *bitmap;
On 2013/02/06 02:30:08, halyavin wrote:
> Please, add brackets around *bitmap.

Hey, NaCl style guide explicitly forbids them:

http://www.chromium.org/nativeclient/styleguide

And it makes sense: Google Style Guide recommends sizeof(varname) instead of
sizeof(typename) and this approach helps to distinguish two cases ("sizeof
varname" is valid C/C++ while "sizeof typename" is not).

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/bitmap.h:32: bitmap = malloc(byte_count);
On 2013/02/06 02:30:08, halyavin wrote:
> We can use calloc and move sizeof here.

Done.

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (left):

https://codereview.chromium.org/12226019/diff/12004/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_32.gyp:11: 'target_defaults': {
On 2013/02/06 02:30:08, halyavin wrote:
> Is it needed for this CL?

No, it's in the same client :-( Removed.

[halyavin, 2013-02-06 08:29:44]

lgtm