base: Convert the remaining uses of MessageLoop::RunUntilIdle to RunLoop variant.

base: Convert the remaining uses of MessageLoop::RunUntilIdle to RunLoop variant.

The former method is deprecated and actually it is just using RunLoop internally.
The later is the cannonical method and should be used instead.

BUG=131220
TEST=base_unittests
R=darin@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180991

[tfarina, 2013-02-05 14:32:24]

Hi Darin, could you review this to me?

Thanks,

[tfarina, 2013-02-05 14:59:01]

No idea, what the errors are about :/

../../base/prefs/json_pref_store_unittest.cc:209:5: error: invalid use of
incomplete type 'base::RunLoop'
    RunLoop().RunUntilIdle();
    ^~~~~~~~~

in this file base/run_loop.h is included and the unit tests are wrapped into
base namespace.

I also did build and run locally.

Must be some gyp issue... :(

[tfarina, 2013-02-05 15:39:14]

passing HEAD to 'git cl try' made it work it seems.

I guess it wasn't picking my recent change that added the run_loop.h include to
json_pref_store_unittest.cc

[darin (slow to review), 2013-02-05 19:20:50]

Can you now remove the RunUntilIdle() function from MessageLoop?

[tfarina, 2013-02-05 19:26:47]

For sure no, not yet. There are thousands of usage on src/chrome, src/chromeos,
src/content/, gpu, ipc, libjingle, and so.

I plan to tackle them, but in their patch series. Like I did with the
base::Passed(...) series.

[darin (slow to review), 2013-02-05 19:27:44]

OK, LGTM

On Tue, Feb 5, 2013 at 11:26 AM, <tfarina@chromium.org> wrote:

> For sure no, not yet. There are thousands of usage on src/chrome,
> src/chromeos,
> src/content/, gpu, ipc, libjingle, and so.
>
> I plan to tackle them, but in their patch series. Like I did with the
> base::Passed(...) series.
>
>
https://codereview.chromium.**org/12226007/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-02-06 13:51:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12226007/7001

[commit-bot: I haz the power, 2013-02-06 16:12:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12226007/7001

[commit-bot: I haz the power, 2013-02-06 16:56:21]

Change committed as 180991