base/prefs/json_pref_store_unittest.cc - Issue 12226007: base: Convert the remaining uses of MessageLoop::RunUntilIdle to RunLoop variant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/json_pref_store_unittest.cc

Issue 12226007: base: Convert the remaining uses of MessageLoop::RunUntilIdle to RunLoop variant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/json_pref_store_unittest.cc

diff --git a/base/prefs/json_pref_store_unittest.cc b/base/prefs/json_pref_store_unittest.cc

index b44d9e56bfd6894d3124e586ef3e2b378a6a0e17..f932988f6bce606ebf3842c10e47ac4467879259 100644

--- a/base/prefs/json_pref_store_unittest.cc

+++ b/base/prefs/json_pref_store_unittest.cc

@@ -207,7 +207,7 @@ TEST_F(JsonPrefStoreTest, BasicAsync) {

EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1);

EXPECT_CALL(*mock_error_delegate,

OnError(PersistentPrefStore::PREF_READ_ERROR_NONE)).Times(0);

- message_loop_.RunUntilIdle();

+ RunLoop().RunUntilIdle();

pref_store->RemoveObserver(&mock_observer);

ASSERT_FALSE(pref_store->ReadOnly());

@@ -244,7 +244,7 @@ TEST_F(JsonPrefStoreTest, AsyncNonExistingFile) {

EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1);

EXPECT_CALL(*mock_error_delegate,

OnError(PersistentPrefStore::PREF_READ_ERROR_NO_FILE)).Times(1);

- message_loop_.RunUntilIdle();

+ RunLoop().RunUntilIdle();

pref_store->RemoveObserver(&mock_observer);

EXPECT_FALSE(pref_store->ReadOnly());

« no previous file with comments | « base/observer_list_unittest.cc ('k') | base/system_monitor/system_monitor_unittest.cc » ('j') | no next file with comments »