test/data/input/style_binding_test.html - Issue 12225039: Support for observable models, fixes #259

Unified Diff: test/data/input/style_binding_test.html

Issue 12225039: Support for observable models, fixes #259 (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test/data/input/recursive_component_test.html ('K') | « test/data/input/root_query_no_shadowroot_test.html ('k') | test/data/input/table_test.html » ('j') | test/data/input/text_multiple_bindings_test.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/data/input/style_binding_test.html

diff --git a/test/data/input/style_binding_test.html b/test/data/input/style_binding_test.html

index 040cca7d4b3500e72f825a742d275b75c88cd674..473727d7ac6cc99494a681797f0368984b952470 100644

--- a/test/data/input/style_binding_test.html

+++ b/test/data/input/style_binding_test.html

@@ -8,7 +8,6 @@ BSD-style license that can be found in the LICENSE file.

<head>

- <title>data_style_binding_test</title>

</head>

<body>

@@ -20,20 +19,31 @@ BSD-style license that can be found in the LICENSE file.

// Note: use const maps to ensure that the system doesn't mutate the map.

// (this would cause a runtime error).

- var styles = const { 'font-size': '16px' };

+ @observable var styles = const { 'font-size': '16px' };

main() {

window.setTimeout(() {

expect(query('#test').style.cssText, 'font-size: 16px;');

var oldStyles = styles;

styles = "Intentionally invalid style!";

- expect(dispatch, throwsA(predicate((x) => x is DataBindingError)));

+ var error = null;

+ onObserveUnhandledError = (e, trace, callback) {

+ error = e;

+ };

+ try {

+ deliverChangesSync();

+ expect(error, new isInstanceOf<DataBindingError>());

Siggi Cherem (dart-lang) 2013/02/13 19:28:54 let's keep this with 'predicate' instead of 'isIns

Jennifer Messerly 2013/02/14 00:38:09 I think it is fixed: https://code.google.com/p/dar

Siggi Cherem (dart-lang) 2013/02/14 00:59:25 good to know...

+ } finally {

+ onObserveUnhandledError = defaultObserveUnhandledError;

+ }

window.setTimeout(() {

// Our invalid style was ignored.

expect(query('#test').style.cssText, '');

styles = const { 'font-size': '24px', 'font-family': 'monospace' };

- dispatch();

+ deliverChangesSync();

window.setTimeout(() {

// This is also verified through the render tree.

expect(query('#test').style.cssText,