test/data/input/style_binding_test.html - Issue 12225039: Support for observable models, fixes #259

Side by Side Diff: test/data/input/style_binding_test.html

Issue 12225039: Support for observable models, fixes #259 (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« test/data/input/recursive_component_test.html ('K') | « test/data/input/root_query_no_shadowroot_test.html ('k') | test/data/input/table_test.html » ('j') | test/data/input/text_multiple_bindings_test.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <!--	2 <!--

3 Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	3 Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

4 for details. All rights reserved. Use of this source code is governed by a	4 for details. All rights reserved. Use of this source code is governed by a

5 BSD-style license that can be found in the LICENSE file.	5 BSD-style license that can be found in the LICENSE file.

6 -->	6 -->

7 <html lang="en">	7 <html lang="en">

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">	10 <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">

11 <title>data_style_binding_test</title>

12 <script type='application/javascript' src="testing.js"></script>	11 <script type='application/javascript' src="testing.js"></script>

13 </head>	12 </head>

14 <body>	13 <body>

15 <p id="test" style="{{styles}}">This text should be 24px monospace</p>	14 <p id="test" style="{{styles}}">This text should be 24px monospace</p>

16 <script type="application/dart">	15 <script type="application/dart">

17 import 'dart:html';	16 import 'dart:html';

18 import 'package:web_ui/web_ui.dart';	17 import 'package:web_ui/web_ui.dart';

19 import 'package:unittest/unittest.dart';	18 import 'package:unittest/unittest.dart';

20	19

21 // Note: use const maps to ensure that the system doesn't mutate the map.	20 // Note: use const maps to ensure that the system doesn't mutate the map.

22 // (this would cause a runtime error).	21 // (this would cause a runtime error).

23 var styles = const { 'font-size': '16px' };	22 @observable var styles = const { 'font-size': '16px' };

24 main() {	23 main() {

25 window.setTimeout(() {	24 window.setTimeout(() {

26 expect(query('#test').style.cssText, 'font-size: 16px;');	25 expect(query('#test').style.cssText, 'font-size: 16px;');

27 var oldStyles = styles;	26 var oldStyles = styles;

28	27

29 styles = "Intentionally invalid style!";	28 styles = "Intentionally invalid style!";

30 expect(dispatch, throwsA(predicate((x) => x is DataBindingError)));	29

	30 var error = null;

	31 onObserveUnhandledError = (e, trace, callback) {

	32 error = e;

	33 };

	34 try {

	35 deliverChangesSync();

	36 expect(error, new isInstanceOf<DataBindingError>());
	Siggi Cherem (dart-lang) 2013/02/13 19:28:54 let's keep this with 'predicate' instead of 'isIns let's keep this with 'predicate' instead of 'isInstanceOf' (isInstanceOf is not supported in dart2js): expect(error, matches(predicate((e) => e is DataBindingError)); Jennifer Messerly 2013/02/14 00:38:09 I think it is fixed: https://code.google.com/p/dar Show quoted text On 2013/02/13 19:28:54, Siggi Cherem (dart-lang) wrote: > let's keep this with 'predicate' instead of 'isInstanceOf' (isInstanceOf is not > supported in dart2js): > > expect(error, matches(predicate((e) => e is DataBindingError)); I think it is fixed: https://code.google.com/p/dart/issues/detail?id=5096 The CL was committed. I figure we can try it on dart2js, if we still see the bug we can switch back. Siggi Cherem (dart-lang) 2013/02/14 00:59:25 good to know... Show quoted text On 2013/02/14 00:38:09, John Messerly wrote: > On 2013/02/13 19:28:54, Siggi Cherem (dart-lang) wrote: > > let's keep this with 'predicate' instead of 'isInstanceOf' (isInstanceOf is > not > > supported in dart2js): > > > > expect(error, matches(predicate((e) => e is DataBindingError)); > > I think it is fixed: > https://code.google.com/p/dart/issues/detail?id=5096 > > The CL was committed. > > I figure we can try it on dart2js, if we still see the bug we can switch back. good to know...
	37 } finally {

	38 onObserveUnhandledError = defaultObserveUnhandledError;

	39 }

	40

31 window.setTimeout(() {	41 window.setTimeout(() {

32 // Our invalid style was ignored.	42 // Our invalid style was ignored.

33 expect(query('#test').style.cssText, '');	43 expect(query('#test').style.cssText, '');

34	44

35 styles = const { 'font-size': '24px', 'font-family': 'monospace' };	45 styles = const { 'font-size': '24px', 'font-family': 'monospace' };

36 dispatch();	46 deliverChangesSync();

37 window.setTimeout(() {	47 window.setTimeout(() {

38 // This is also verified through the render tree.	48 // This is also verified through the render tree.

39 expect(query('#test').style.cssText,	49 expect(query('#test').style.cssText,

40 'font-size: 24px; font-family: monospace;');	50 'font-size: 24px; font-family: monospace;');

41 window.postMessage('done', '*');	51 window.postMessage('done', '*');

42 }, 0);	52 }, 0);

43 }, 0);	53 }, 0);

44 }, 0);	54 }, 0);

45 }	55 }

46 </script>	56 </script>

47 </body>	57 </body>

48 </html>	58 </html>

OLD	NEW