Issue 12223120: Restore the 'Create Shortcuts...' menu item for v1 apps on !mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223120: Restore the 'Create Shortcuts...' menu item for v1 apps on !mac. (Closed)

Created:
7 years, 10 months ago by jeremya

Modified:
7 years, 10 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore the 'Create Shortcuts...' menu item for v1 apps on !mac. The shortcut code on mac can only handle v2 apps, so we keep the menu item hidden there. BUG=175691 R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182172

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/resources/ntp4/apps_page.js	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/12223120/1

7 years, 10 months ago (2013-02-13 05:26:54 UTC) #4

Message was sent while issue was closed.

Change committed as 182172

Expand Messages | Collapse Messages