Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1873)

Unified Diff: chrome/browser/resources/ntp4/apps_page.js

Issue 12223120: Restore the 'Create Shortcuts...' menu item for v1 apps on !mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/apps_page.js
diff --git a/chrome/browser/resources/ntp4/apps_page.js b/chrome/browser/resources/ntp4/apps_page.js
index 21f5062ab97680733e16d39453d3235d37c38621..4fecaa6c564cf9787144431aef830264304491ec 100644
--- a/chrome/browser/resources/ntp4/apps_page.js
+++ b/chrome/browser/resources/ntp4/apps_page.js
@@ -150,8 +150,13 @@ cr.define('ntp', function() {
this.disableNotifications_.hidden = false;
this.disableNotifications_.checked = notificationsDisabled;
}
- this.createShortcutSeparator_.hidden = this.createShortcut_.hidden =
- !app.appData.packagedApp;
+ if (cr.isMac) {
+ // On Windows and Linux, these should always be visible. On ChromeOS,
+ // they are never created. On Mac, shortcuts can only be created for
+ // new-style packaged apps, so hide the menu item.
+ this.createShortcutSeparator_.hidden = this.createShortcut_.hidden =
+ !app.appData.packagedApp;
+ }
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698