Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 12221150: Unselect text before rotating (Closed)

Created:
7 years, 10 months ago by cjhopman
Modified:
7 years, 10 months ago
Reviewers:
nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Unselect text before rotating When rotating, we receive events from the renderer in an unexpected order (we get a SelectionBoundsChanged call with points in the new window position before the CompositorFrameMessage and so we misinterpret the SelectionBoundsChanged). For now, we should simply unselect the text before rotating. BUG=174665 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182074

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
nileshagrawal: *
7 years, 10 months ago (2013-02-12 21:37:48 UTC) #1
nilesh
On 2013/02/12 21:37:48, cjhopman wrote: > nileshagrawal: * LGTM
7 years, 10 months ago (2013-02-12 21:40:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12221150/2001
7 years, 10 months ago (2013-02-12 21:48:04 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 01:10:36 UTC) #4
Message was sent while issue was closed.
Change committed as 182074

Powered by Google App Engine
This is Rietveld 408576698