Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 12221150: Unselect text before rotating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index a6441ffe1b9b3e815d151d82a2d571825c0ef59c..7c1ecf4b7b5770acc71b15d262eca7bd8102d2a9 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1334,6 +1334,12 @@ public class ContentViewCore implements MotionEventDelegate, NavigationClient {
}
if (mNeedUpdateOrientationChanged) {
+ // TODO(cjhopman): Once selection bounds are received from the renderer as absolute
+ // positions, we will no longer need to unselect before rotation (though we may decide
+ // it is the correct behavior).
+ // http://crbug.com/174665
+ mImeAdapter.unselect();
+
sendOrientationChangeEvent();
mNeedUpdateOrientationChanged = false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698