Support JellyBean MR2 style of systrace

Support JellyBean MR2 style of systrace

JB MR2 systrace.py combined the steps of trace tags settings and
trace collection into one step, so we need to react to the change
of trace tags settings to enable/disable atrace in chrome.

The change also benefit pre-JB-MR2 systems that we don't need to
restart chrome after changing the trace tags settings in Developer
options. However, we still need "adb shell stop; adb shell start"
if we set the trace tags using pre-JB-MR2 systrace.py.

BUG=173954
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182739

[klobag.chromium, 2013-02-08 02:31:32]

"adb shell stop/start" will restart the android runtime. Can we avoid it? e.g.
keep the old way for pre-jb-mr2.

[Xianzhu, 2013-02-08 02:41:11]

On 2013/02/08 02:31:32, klobag.chromium wrote:
> "adb shell stop/start" will restart the android runtime. Can we avoid it? e.g.
> keep the old way for pre-jb-mr2.

On pre-jb-mr2, "Adb shell stop/start" is only required if using systrace.py
command line to enable systrace tags. Won't need it if setting it using
Settings/Developer options UI.

[Xianzhu, 2013-02-12 21:58:44]

Jay & Grace, does this patch lgty?

[Jay Civelli, 2013-02-13 18:24:02]

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(right):

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:77:
String propertyTraceTagEnableFlags = (String)traceClass.getField(
Nit: missing space after (String)

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:83:
int enabledTags = (Integer) systemPropertiesGetIntMethod.invoke(
Nit: should it be named enableFlags?

[Xianzhu, 2013-02-13 21:50:17]

Add jar@ for base/debug/.

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(right):

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:77:
String propertyTraceTagEnableFlags = (String)traceClass.getField(
On 2013/02/13 18:24:02, Jay Civelli wrote:
> Nit: missing space after (String)

Done.

https://codereview.chromium.org/12221047/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:83:
int enabledTags = (Integer) systemPropertiesGetIntMethod.invoke(
On 2013/02/13 18:24:02, Jay Civelli wrote:
> Nit: should it be named enableFlags?

Done.

[Xianzhu, 2013-02-14 17:26:58]

ping...

[jar (doing other things), 2013-02-14 17:39:43]

patch set 2, base LGTM

[Jay Civelli, 2013-02-14 17:56:28]

LGTM

https://chromiumcodereview.appspot.com/12221047/diff/7001/content/public/andr...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(right):

https://chromiumcodereview.appspot.com/12221047/diff/7001/content/public/andr...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:81:
Method systemPropertiesGetIntMethod = systemPropertiesClass.getDeclaredMethod(
Nit: rename systemPropertiesGetLongMethod

[Xianzhu, 2013-02-14 18:00:55]

https://chromiumcodereview.appspot.com/12221047/diff/7001/content/public/andr...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(right):

https://chromiumcodereview.appspot.com/12221047/diff/7001/content/public/andr...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:81:
Method systemPropertiesGetIntMethod = systemPropertiesClass.getDeclaredMethod(
On 2013/02/14 17:56:28, Jay Civelli wrote:
> Nit: rename systemPropertiesGetLongMethod

Done.

[commit-bot: I haz the power, 2013-02-14 18:02:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/12221047/10003

[commit-bot: I haz the power, 2013-02-14 22:19:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/12221047/10003

[commit-bot: I haz the power, 2013-02-15 11:28:11]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-15 17:05:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/12221047/10003

[commit-bot: I haz the power, 2013-02-15 17:24:45]

Change committed as 182739