Fixes a DCHECK failure while invoking permission link

Fixes a DCHECK failure while invoking permission link

BUG=175893
TEST=Click on permission link and no DCHECK in debug builds.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182837

[Joe Thomas, 2013-02-13 01:03:30]

Please take a look. Thanks

[Finnur, 2013-02-13 12:46:11]

LGTM. Thanks!

[Finnur, 2013-02-13 12:46:45]

Nit: TEST= should say 'no DCHECK', not 'no crash'.

[Joe Thomas, 2013-02-13 15:51:37]

On 2013/02/13 12:46:45, Finnur wrote:
> Nit: TEST= should say 'no DCHECK', not 'no crash'.

Done. Thanks for the review.

[Joe Thomas, 2013-02-13 15:53:13]

+Evan Stade for ui/gtk

[Evan Stade, 2013-02-13 21:25:13]

lgtm

[commit-bot: I haz the power, 2013-02-13 23:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/1

[commit-bot: I haz the power, 2013-02-13 23:00:35]

Failed to apply patch for chrome/browser/extensions/extension_install_prompt.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_install_prompt.h
  Hunk #1 FAILED at 83.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_install_prompt.h.rej

Patch:       chrome/browser/extensions/extension_install_prompt.h
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h
b/chrome/browser/extensions/extension_install_prompt.h
index
0f1b18cd0700222eadf5fc592cf9bb5ffec57337..d2ab087c1f4e2ebc7d32e106c98343d294a09149
100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -83,6 +83,7 @@ class ExtensionInstallPrompt
     string16 GetDialogTitle() const;
     string16 GetHeading() const;
     int GetDialogButtons() const;
+    bool HasAcceptButtonLabel() const;
     string16 GetAcceptButtonLabel() const;
     bool HasAbortButtonLabel() const;
     string16 GetAbortButtonLabel() const;

[Joe Thomas, 2013-02-13 23:00:59]

Permission feature is reverted today as it broke on Mac (issue 175071). But
committing this CL as it does not depend on permission stuff directly.

[commit-bot: I haz the power, 2013-02-13 23:43:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/7003

[commit-bot: I haz the power, 2013-02-14 00:10:56]

Retried try job too often on linux_chromeos for step(s) aura_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, check_deps,
chromeos_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, dbus_unittests, device_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-02-14 01:11:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/7003

[commit-bot: I haz the power, 2013-02-14 01:43:55]

Retried try job too often on linux_chromeos for step(s) aura_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, check_deps,
chromeos_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, dbus_unittests, device_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-02-14 02:58:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/7003

[commit-bot: I haz the power, 2013-02-14 14:44:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/7003

[commit-bot: I haz the power, 2013-02-15 19:29:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/12220142/18001

[commit-bot: I haz the power, 2013-02-15 21:51:43]

Change committed as 182837