Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 12220142: Fixes a DCHECK failure while invoking permission link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
index c11b9dc7420ed03bbe799ce4b536c3699c8323c1..c8a9c966e9f605ecf3f579300f13a47475b09944 100644
--- a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc
@@ -135,10 +135,12 @@ ExtensionInstallDialog::ExtensionInstallDialog(
prompt.HasAbortButtonLabel() ?
UTF16ToUTF8(prompt.GetAbortButtonLabel()).c_str() : GTK_STOCK_CANCEL,
GTK_RESPONSE_CLOSE);
- gtk_dialog_add_button(
- GTK_DIALOG(dialog_),
- UTF16ToUTF8(prompt.GetAcceptButtonLabel()).c_str(),
- GTK_RESPONSE_ACCEPT);
+ if (prompt.HasAcceptButtonLabel()) {
+ gtk_dialog_add_button(
+ GTK_DIALOG(dialog_),
+ UTF16ToUTF8(prompt.GetAcceptButtonLabel()).c_str(),
+ GTK_RESPONSE_ACCEPT);
+ }
#if !GTK_CHECK_VERSION(2, 22, 0)
gtk_dialog_set_has_separator(GTK_DIALOG(dialog_), FALSE);
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698