Issue 12220140: [nacltoons] Cleanup initial game code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12220140: [nacltoons] Cleanup initial game code. (Closed)

Created:
7 years, 10 months ago by Sam Clegg

Modified:
7 years, 10 months ago

Reviewers:
noelallen_use_chromium, noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[nacltoons] Cleanup initial game code. Changes based on feedback from https://codereview.chromium.org/12226130/ BUG=None Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1505

Patch Set 1 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -42 lines)			Patch
M	nacltoons/src/app_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	nacltoons/src/app_delegate.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	nacltoons/src/frontend.h	View	1 chunk	+20 lines, -7 lines	0 comments	Download
M	nacltoons/src/frontend.cc	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	nacltoons/src/gameplay_scene.h	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	nacltoons/src/gameplay_scene.cc	View	2 chunks	+18 lines, -15 lines	0 comments	Download
M	nacltoons/src/physics_layer.h	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

noelallen_use_chromium

7 years, 10 months ago (2013-02-13 00:22:41 UTC) #2

lgtm

https://codereview.chromium.org/12220140/diff/3001/nacltoons/src/app_delegate.cc
File nacltoons/src/app_delegate.cc (right):

https://codereview.chromium.org/12220140/diff/3001/nacltoons/src/app_delegate...
nacltoons/src/app_delegate.cc:16: // Craete the initial (autorelease) scene and
run with it.
Create

Expand Messages | Collapse Messages