Refactor in preparation for SPDY 4, part 1.

Refactor in preparation for SPDY 4, part 1.

Zero behavioral change to the on-the-wire format nor protocol semantics.

This lands server change 40997047.

Also create spdy_protocol.cc and move some functions to it to
avoid clang warnings.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182053

[akalin, 2013-02-12 07:00:12]

+rch for review

[Ryan Hamilton, 2013-02-12 16:34:52]

lgtm

https://chromiumcodereview.appspot.com/12220116/diff/1/net/spdy/spdy_frame_bu...
File net/spdy/spdy_frame_builder.h (right):

https://chromiumcodereview.appspot.com/12220116/diff/1/net/spdy/spdy_frame_bu...
net/spdy/spdy_frame_builder.h:34: SpdyFrameBuilder(SpdyControlType type, uint8
flags,
After you get this all moved around and finish landing all of these internal
changes, can you add a typedef for this uint8?

[akalin, 2013-02-12 20:01:17]

https://codereview.chromium.org/12220116/diff/1/net/spdy/spdy_frame_builder.h
File net/spdy/spdy_frame_builder.h (right):

https://codereview.chromium.org/12220116/diff/1/net/spdy/spdy_frame_builder.h...
net/spdy/spdy_frame_builder.h:34: SpdyFrameBuilder(SpdyControlType type, uint8
flags,
On 2013/02/12 16:34:52, Ryan Hamilton wrote:
> After you get this all moved around and finish landing all of these internal
> changes, can you add a typedef for this uint8?

Okay.  Added a TODO.

[commit-bot: I haz the power, 2013-02-12 20:03:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/12220116/8003

[commit-bot: I haz the power, 2013-02-12 23:07:45]

Change committed as 182053