Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: net/spdy/spdy_frame_builder.cc

Issue 12220116: Refactor in preparation for SPDY 4, part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile errors Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_frame_builder.h ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "net/spdy/spdy_frame_builder.h" 7 #include "net/spdy/spdy_frame_builder.h"
8 #include "net/spdy/spdy_protocol.h" 8 #include "net/spdy/spdy_protocol.h"
9 9
10 namespace net { 10 namespace net {
11 11
12 namespace { 12 namespace {
13 13
14 // Creates a FlagsAndLength. 14 // Creates a FlagsAndLength.
15 FlagsAndLength CreateFlagsAndLength(SpdyControlFlags flags, size_t length) { 15 FlagsAndLength CreateFlagsAndLength(uint8 flags, size_t length) {
16 DCHECK_EQ(0u, length & ~static_cast<size_t>(kLengthMask)); 16 DCHECK_EQ(0u, length & ~static_cast<size_t>(kLengthMask));
17 FlagsAndLength flags_length; 17 FlagsAndLength flags_length;
18 flags_length.length_ = htonl(static_cast<uint32>(length)); 18 flags_length.length_ = htonl(static_cast<uint32>(length));
19 DCHECK_EQ(0, flags & ~kControlFlagsMask); 19 DCHECK_EQ(0, flags & ~kControlFlagsMask);
20 flags_length.flags_[0] = flags; 20 flags_length.flags_[0] = flags;
21 return flags_length; 21 return flags_length;
22 } 22 }
23 23
24 } // namespace 24 } // namespace
25 25
26 SpdyFrameBuilder::SpdyFrameBuilder(size_t size) 26 SpdyFrameBuilder::SpdyFrameBuilder(size_t size)
27 : buffer_(new char[size]), 27 : buffer_(new char[size]),
28 capacity_(size), 28 capacity_(size),
29 length_(0) { 29 length_(0) {
30 } 30 }
31 31
32 SpdyFrameBuilder::SpdyFrameBuilder(SpdyControlType type, 32 SpdyFrameBuilder::SpdyFrameBuilder(SpdyControlType type,
33 SpdyControlFlags flags, 33 uint8 flags,
34 int spdy_version, 34 int spdy_version,
35 size_t size) 35 size_t size)
36 : buffer_(new char[size]), 36 : buffer_(new char[size]),
37 capacity_(size), 37 capacity_(size),
38 length_(0) { 38 length_(0) {
39 FlagsAndLength flags_length = CreateFlagsAndLength( 39 FlagsAndLength flags_length = CreateFlagsAndLength(
40 flags, size - SpdyFrame::kHeaderSize); 40 flags, size - SpdyFrame::kHeaderSize);
41 WriteUInt16(kControlFlagMask | spdy_version); 41 WriteUInt16(kControlFlagMask | spdy_version);
42 WriteUInt16(type); 42 WriteUInt16(type);
43 WriteBytes(&flags_length, sizeof(flags_length)); 43 WriteBytes(&flags_length, sizeof(flags_length));
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 bool SpdyFrameBuilder::WriteStringPiece32(const base::StringPiece& value) { 101 bool SpdyFrameBuilder::WriteStringPiece32(const base::StringPiece& value) {
102 if (!WriteUInt32(value.size())) { 102 if (!WriteUInt32(value.size())) {
103 return false; 103 return false;
104 } 104 }
105 105
106 return WriteBytes(value.data(), value.size()); 106 return WriteBytes(value.data(), value.size());
107 } 107 }
108 108
109 } // namespace net 109 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_frame_builder.h ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698