Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_socket.h

Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing completion callback implementation. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_tcp_socket.h
diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket.h b/content/browser/renderer_host/pepper/pepper_tcp_socket.h
index 9bebd5b9c914ee8434fb085d10c8c25e374d20ee..3efdcffeaf64d831b1b9b17f3a9bdfcc2956a243 100644
--- a/content/browser/renderer_host/pepper/pepper_tcp_socket.h
+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket.h
@@ -60,6 +60,7 @@ class PepperTCPSocket {
const std::vector<std::vector<char> >& untrusted_certs);
void Read(int32 bytes_to_read);
void Write(const std::string& data);
+ void SetBoolFeature(uint32_t name, bool value);
yzshen1 2013/02/08 21:51:11 I noticed that in pepper_message_filter, |name| is
Wez 2013/02/10 04:47:02 No; I just followed the style of the UDP SetBoolSo
yzshen1 2013/02/12 17:39:58 I didn't see that you have switched to enum. Have
Wez 2013/02/12 18:45:21 Yes; see PepperPluginDelegateImpl. This SetBoolFe
yzshen1 2013/02/13 08:07:14 You could directly use the enum over IPC, and use
void SendConnectACKError();
@@ -95,6 +96,7 @@ class PepperTCPSocket {
void SendReadACKError();
void SendWriteACKError();
void SendSSLHandshakeACK(bool succeeded);
+ void SendSetBoolFeatureACK(bool succeeded);
void OnResolveCompleted(int result);
void OnConnectCompleted(int result);
@@ -103,6 +105,7 @@ class PepperTCPSocket {
void OnWriteCompleted(int result);
bool IsConnected() const;
+ bool IsSsl() const;
// Actually does a write from |write_buffer_|; possibly called many times for
// each |Write()|.

Powered by Google App Engine
This is Rietveld 408576698