Provide a way to disable Nagle's algorithm on Pepper TCP sockets.

content/browser/renderer_host/pepper/pepper_tcp_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SOCKET_H_
 #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SOCKET_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 42 matching lines @@
 
   void Connect(const std::string& host, uint16_t port);
   void ConnectWithNetAddress(const PP_NetAddress_Private& net_addr);
   void SSLHandshake(
       const std::string& server_name,
       uint16_t server_port,
       const std::vector<std::vector<char> >& trusted_certs,
       const std::vector<std::vector<char> >& untrusted_certs);
   void Read(int32 bytes_to_read);
   void Write(const std::string& data);
+  void SetBoolFeature(uint32_t name, bool value);

[yzshen1, 2013/02/08 21:51:11]

I noticed that in pepper_message_filter, |name| is int32_t.
Is it intentional to be different?

And I think it is better to pass PP_TCPSocketFeature_Private directly.

[Wez, 2013/02/10 04:47:02]

No; I just followed the style of the UDP SetBoolSocketFeature implementation. 
Fixed.
I based this on the UDP SetSocketFeature implementation, which uses int32_t
here, but I've switched these to use the enum.

[yzshen1, 2013/02/12 17:39:58]

I didn't see that you have switched to enum. Have you uploaded the latest patch?

[Wez, 2013/02/12 18:45:21]

Yes; see PepperPluginDelegateImpl.  This SetBoolFeature() is called by
PepperMessageFilter w/ a uint32_t "name" received via IPC, so to switch this to
an enum would require duplicating knowledge of the valid values.

[yzshen1, 2013/02/13 08:07:14]

You could directly use the enum over IPC, and use it at the host side.
For example, see:
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/proxy/ppapi_...

On 2013/02/12 18:45:21, Wez wrote:

 
   void SendConnectACKError();
 
   // Extracts the certificate field data from a |net::X509Certificate| into
   // |PPB_X509Certificate_Fields|.
   static bool GetCertificateFields(const net::X509Certificate& cert,
                                    ppapi::PPB_X509Certificate_Fields* fields);
   // Extracts the certificate field data from the DER representation of a
   // certificate into |PPB_X509Certificate_Fields|.
   static bool GetCertificateFields(const char* der,
@@ skipping 15 matching lines @@
     SSL_CONNECTED,
     // An SSL handshake has failed.
     SSL_HANDSHAKE_FAILED
   };
 
   void StartConnect(const net::AddressList& addresses);
 
   void SendReadACKError();
   void SendWriteACKError();
   void SendSSLHandshakeACK(bool succeeded);
+  void SendSetBoolFeatureACK(bool succeeded);
 
   void OnResolveCompleted(int result);
   void OnConnectCompleted(int result);
   void OnSSLHandshakeCompleted(int result);
   void OnReadCompleted(int result);
   void OnWriteCompleted(int result);
 
   bool IsConnected() const;
+  bool IsSsl() const;
 
   // Actually does a write from |write_buffer_|; possibly called many times for
   // each |Write()|.
   void DoWrite();
 
   PepperMessageFilter* manager_;
   int32 routing_id_;
   uint32 plugin_dispatcher_id_;
   uint32 socket_id_;
 
@@ skipping 13 matching lines @@
   // using a |DrainableIOBuffer|, which requires an underlying base |IOBuffer|.
   scoped_refptr<net::IOBuffer> write_buffer_base_;
   scoped_refptr<net::DrainableIOBuffer> write_buffer_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperTCPSocket);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SOCKET_H_