Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 12218098: [Test Expectations] Add GetCurrentPlatform() and GetCurrentConfiguration(). (Closed)

Created:
7 years, 10 months ago by Robert Sesek
Modified:
7 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

[Test Expectations] Add GetCurrentPlatform() and GetCurrentConfiguration(). BUG=173176 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181793

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4 lines) Patch
M base/test/expectations/expectation.h View 2 chunks +6 lines, -0 lines 0 comments Download
M base/test/expectations/expectation.cc View 1 2 4 chunks +62 lines, -2 lines 0 comments Download
M base/test/expectations/expectation_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
This is small.
7 years, 10 months ago (2013-02-11 21:54:47 UTC) #1
Mark Mentovai
LGTM
7 years, 10 months ago (2013-02-11 21:57:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/12218098/3014
7 years, 10 months ago (2013-02-11 22:00:27 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-11 23:52:43 UTC) #4
Message was sent while issue was closed.
Change committed as 181793

Powered by Google App Engine
This is Rietveld 408576698