Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Unified Diff: base/test/expectations/expectation_unittest.cc

Issue 12218098: [Test Expectations] Add GetCurrentPlatform() and GetCurrentConfiguration(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/expectations/expectation.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/expectations/expectation_unittest.cc
diff --git a/base/test/expectations/expectation_unittest.cc b/base/test/expectations/expectation_unittest.cc
index c355d1a6d736632fb869c719e6b60e7dd623e4fb..8a7af71a97eb0274eb77734c818bb2b412c539c2 100644
--- a/base/test/expectations/expectation_unittest.cc
+++ b/base/test/expectations/expectation_unittest.cc
@@ -82,8 +82,8 @@ TEST(TestExpectationsFunctionsTest, IsValidPlatform) {
"Mac-10.7",
"Mac-10.8",
"Linux",
- "Linux-x32",
- "Linux-x64",
+ "Linux-32",
+ "Linux-64",
"ChromeOS",
"iOS",
"Android",
@@ -106,3 +106,15 @@ TEST(TestExpectationsFunctionsTest, IsValidPlatform) {
kInvalidPlatforms[i], &platform)) << kInvalidPlatforms[i];
}
}
+
+TEST(TestExpectationsFunctionsTest, CurrentPlatform) {
+ test_expectations::Platform current =
+ test_expectations::GetCurrentPlatform();
+ EXPECT_FALSE(current.name.empty());
+}
+
+TEST(TestExpectationsFunctionsTest, CurrentConfiguration) {
+ test_expectations::Configuration current =
+ test_expectations::GetCurrentConfiguration();
+ EXPECT_NE(test_expectations::CONFIGURATION_UNSPECIFIED, current);
+}
« no previous file with comments | « base/test/expectations/expectation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698