Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 12218057: Disable cookies when fetching favicon. (Closed)

Created:
7 years, 10 months ago by Philippe
Modified:
7 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, kenjibaheux, eroman
Visibility:
Public.

Description

Disable cookies when fetching favicon. Processing cookies in a favicon response can cause undesirable side effects on the cookie store. Some websites break because of this. In particular it was impossible to login on linkedin on Android with desktop user agent due to a 404 response with side effects on cookies (including the authentication token cookie) for a /apple-touch-icon.png request. BUG=171103, 114082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webkit/glue/resource_fetcher.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Philippe
7 years, 10 months ago (2013-02-07 18:01:04 UTC) #1
erikwright (departed)
LGTM.
7 years, 10 months ago (2013-02-07 18:34:31 UTC) #2
brettw
lgtm
7 years, 10 months ago (2013-02-07 20:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/12218057/1
7 years, 10 months ago (2013-02-08 10:12:54 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 11:27:07 UTC) #5
Message was sent while issue was closed.
Change committed as 181483

Powered by Google App Engine
This is Rietveld 408576698